Re: Hiding 'new' statements - Good or Evil?

2017-11-27 Thread Michael Froman
On Nov 27, 2017, at 6:07 PM, smaug wrote: > > And auto makes code reading harder. It hides important information like > lifetime management. > It happens easily with auto that one doesn't even start to think whether > nsCOMPtr/RefPtr should be used there. > > I'm saying this all with my review

Re: Stylesheet wait timeout?

2017-08-31 Thread Michael Froman
> On Aug 31, 2017, at 1:08 PM, Boris Zbarsky wrote: > > The symptoms you observe sound like (A) is happening, possible from an > extension or our browser UI... If you have a link to a specific url that > reproduces for you, especially in a clean profile, that would be pretty > useful. This

Re: Should &&/|| really be at the end of lines?

2017-02-18 Thread Michael Froman
> On Feb 17, 2017, at 6:24 PM, ISHIKAWA,chiaki wrote: > > Point 2: > I prefer all the operators including "&&" and "||" > at the beginning since such a format makes the tree-like structure of > multi-line easier to understand and edit, too. > Adding a condition or removing a condition is much e

Re: Rust required to build Gecko

2016-11-28 Thread Michael Froman
See inline. > On Nov 28, 2016, at 11:37 AM, Ralph Giles wrote: > > On Mon, Nov 28, 2016 at 9:28 AM, Michael Froman wrote: > >> Any thoughts? Further info: >> mfroman-23602:moz-central mfroman$ which rustc >> /Users/mfroman/.cargo/bin/rustc >> mfro

Re: Rust required to build Gecko

2016-11-28 Thread Michael Froman
I tried the bootstrap on OS X (after a fresh pull from mozilla-central this morning), and I also have failures. I’ve added the following lines to my .profile: export PATH="$HOME/.cargo/bin:$PATH" source /Users/mfroman/.cargo/env I continue to get errors from the bootstrap process: The details o