Intent to implement: `//# sourceURL=display-url.js` in Error.prototype.stack

2014-10-09 Thread Fitzgerald, Nick
# Summary By appending "//# sourceURL=foo.js" to script text that is being passed to `eval`, `new Function`, or as the text content of a dynamically appended

Using protobuf in m-c

2014-09-24 Thread Fitzgerald, Nick
Hey folks, We already have the protobuf library in the tree, and it seems to be used for layer scope and webrtc. I'd like to use it for serializing heap snapshots in devtools code, but I have a couple questions: * How do I integrate the compilation of the message description (.proto file)

Re: PSA: ./mach build doesn't work reliably any longer

2014-08-25 Thread Fitzgerald, Nick
On 8/25/14, 8:37 AM, Gregory Szorc wrote: How fast do "no-op" / light builds need to be for |mach build | to not exist? About 10 seconds to compete with my usage[0] of |./mach build | for hacking on devtools. Of course, getting even faster is always appreciated ;) [0] Actual command I ru

Re: Are you interested in doing dynamic analysis of JS code?

2014-06-30 Thread Fitzgerald, Nick
On 6/25/14, 8:15 AM, Jason Orendorff wrote: We're considering building a JavaScript API for dynamic analysis of JS code. Here's the sort of thing you could do with it: - Gather code coverage information (useful for testing/release mgmt?) - Trace all object mutation and method calls (useful

Re: JS assertions that get optimized away!

2014-06-27 Thread Fitzgerald, Nick
On 6/27/14, 8:49 AM, Jason Orendorff wrote: On 06/26/2014 06:59 AM, David Rajchenbach-Teller wrote: I would be interested in adding boundary checks and invariant checks that could be eliminated in opt builds. Is this in the scope of your project? No, I don't think so. S2S could certainly do i

Re: Are you interested in doing dynamic analysis of JS code?

2014-06-25 Thread Fitzgerald, Nick
On 6/25/14, 1:06 PM, Jason Orendorff wrote: An alternative involves letting you modify JS code just before it's compiled (source-to-source transformation). This is more general (you could modify the instrumented code arbitrarily, and react synchronously as it executes) but maybe that's undesira

Re: Are you interested in doing dynamic analysis of JS code?

2014-06-25 Thread Fitzgerald, Nick
Yes!! On 6/25/14, 8:15 AM, Jason Orendorff wrote: We're considering building a JavaScript API for dynamic analysis of JS code. Here's the sort of thing you could do with it: - Gather code coverage information (useful for testing/release mgmt?) Yes! We'd absolutely love to show code coverag

Re: bugzilla can now show bugs that have been updated since you last visited them

2014-06-11 Thread Fitzgerald, Nick
On 6/3/14, 11:34 PM, Byron Jones wrote: thanks to dylan's work on bug 489028, bugzilla now tracks when you view a bug, allowing you to search for bugs which have been updated since you last visited them. see my blog post for more details: http://wp.me/p1JUqW-9M You might check out http://bu

Re: Disabling strict warnings as errors in xpcshell

2014-05-07 Thread Fitzgerald, Nick
On 5/7/14, 4:21 PM, Gavin Sharp wrote: What does "get rid of strict warnings as errors for xpcshell tests" mean in practice? It means that our non-standard spidermonkey "strict mode" (not the actual strict mode) console warnings would continue to simply be console warning messages rather than

Re: Disabling strict warnings as errors in xpcshell

2014-05-06 Thread Fitzgerald, Nick
On 5/6/14, 5:31 PM, Jonas Sicking wrote: Are these warnings ever useful enough that this is worth it? Personally, I think not. Bill seemed to really like them. *shrug* This was why I thought it might be easier to just make it optional. ___ dev-platfo

Re: Disabling strict warnings as errors in xpcshell

2014-05-06 Thread Fitzgerald, Nick
On 5/6/14, 3:29 PM, Bill McCloskey wrote: - Original Message - From: "Chris Peterson" To: dev-platform@lists.mozilla.org Sent: Tuesday, May 6, 2014 3:11:40 PM Subject: Re: Disabling strict warnings as errors in xpcshell btw, I believe the JS team now uses the term "extra warnings" to d

Re: Disabling strict warnings as errors in xpcshell

2014-05-06 Thread Fitzgerald, Nick
The most annoying thing for me (other than seemingly arbitrary changes causing whole suites to fail despite correct functionality) is that it breaks duck typing and causes code like: if (obj.quacks) { ... } to fail tests. So in these cases, we are forced to write code something like:

Re: Too many system compartments at start-up

2014-04-24 Thread Fitzgerald, Nick
On 4/24/14, 1:51 AM, Nicholas Nethercote wrote: There are still 16 compartments whose name includes "devtools", for example. Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1001131 for lazily loading devtools modules where it makes sense. ___ dev

Re: displayURL is set asynchronously?

2014-03-10 Thread Fitzgerald, Nick
On 3/10/14 4:24 AM, Jan Honza Odvarko wrote: > Debugger.script.source.displayURL isn't available for new Function scripts > that contain the //# sourceURL directive when accessing it within > Debugger.onNewScript hook. > > It's properly set when testing the flag after timeout. > > Note that it's

Re: Column numbers appended to URLs recently

2014-03-03 Thread Fitzgerald, Nick
This was before that bug. See ComputeStackString: http://dxr.mozilla.org/mozilla-central/source/js/src/jsexn.cpp?from=jsexn.cpp#206 The format is: [] @ : : The last : and is what was added in that bug. I guess the port-or-line-number question is unambiguous if there is *always* a line num

Re: Mozilla style guide issues, from a JS point of view

2014-01-07 Thread Fitzgerald, Nick
On 1/7/14 11:23 AM, Neil wrote: > Martin Thomson wrote: > >> in JS, a case that I’ve encountered several times: >> _classMethodName: function >> ReasonableClassName__classMethodName(argument1, argument2) { >> > I thought that our debugging story had improved sufficiently that we > didn't

Re: Removal of native notification systems on desktop platforms

2013-10-25 Thread Fitzgerald, Nick
Removal of native notifications has badly regressed the UI for notifying that there is a browser update downloaded, and that you can restart the browser to run the new version. (At least on OSX, I don't know about other platforms.) When we had native notifications, you would see a notification, bu