Re: Improvements to the Sphinx in-tree documentation generation

2013-12-16 Thread Brandon Benvie
On 12/16/2013 12:57 PM, Andrew Sutherland wrote: The Esprima JS parser can already generate comment nodes. The API otherwise conforms to the same output standards as SpiderMonkey's Parser API. There's also acorn, which is an ES5 parser written in JS that's in the tree (http://mxr.mozilla.or

Re: Intent to replace Promise.jsm and promise.js with DOM Promises

2013-11-20 Thread Brandon Benvie
On 11/20/2013 9:27 PM, Philip Chee wrote: Currently, I'm getting this in the Error Console a few seconds after startup: Thu Nov 21 2013 13:23:23 Error: A promise chain failed to handle a rejection. Date: Thu Nov 21 2013 13:23:13 GMT+0800 (Malay Peninsula Standard Time) Full Message: [object St

Re: Intent to replace Promise.jsm and promise.js with DOM Promises

2013-11-19 Thread Brandon Benvie
On 11/19/2013 10:12 AM, nsm.nik...@gmail.com wrote: Is there are reason devtools cannot switch to DOM Promises directly rather than go through making Promise.jsm a wrapper around DOM Promise? The current promise implementations which allow resolving later are leading to very un-idiomatic promi

Re: Intent to replace Promise.jsm and promise.js with DOM Promises

2013-11-18 Thread Brandon Benvie
On 11/18/2013 4:54 PM, Dave Townsend wrote: There are add-ons using the existing promises implementations. Is there any reason not to make those wrappers around the DOM promises to avoid potential bustage? At least the add-on SDK promises library provides functionality beyond that that appears t

Re: Coding style for functions called by Task.jsm tasks

2013-10-08 Thread Brandon Benvie
On 10/8/2013 12:34 PM, Gregory Szorc wrote: Also, this JS is invalid because a generator function cannot return a value through "return." For people learning at home, a working implementation is: function add2(a, b) { return Task.spawn(function () { let sum = yield a + b; throw new T

Re: XPIDL & Promises

2013-07-30 Thread Brandon Benvie
On 7/30/2013 1:41 PM, Boris Zbarsky wrote: On 7/30/13 1:37 PM, Gavin Sharp wrote: We'll need to investigate whether the implementations are compatible, though That's fair. DOM Promises are definitely modeled after Promises/A+, but the APIs might not quite match up. :( They don't. With DOM