Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Adam Gashlin
Is this https://bugzilla.mozilla.org/show_bug.cgi?id=1427313 ? On Mon, Aug 19, 2019 at 5:27 PM Kris Maglione wrote: > This is apparently a known bug that no-one seems to be able to > track down the cause of. It suddenly started happening to me one > night for every build, even if I changed nothi

Re: Intent to implement and ship: HTMLMediaElement.allowedToPlay

2018-07-31 Thread Adam Gashlin
I don't think that Netflix would accept allowedToPlay == false for media which is the whole point of visiting a page. They probably wouldn't even check it then, instead allowing for the possibility that the user will be prompted or that it just won't autoplay if they expressed that preference. This

Re: Rust crate approval

2018-06-28 Thread Adam Gashlin
On Thu, Jun 28, 2018 at 4:42 PM, Nathan Froyd wrote: > Thanks for raising these points. > Thanks for the response! On Tue, Jun 26, 2018 at 10:02 PM, Adam Gashlin wrote: > > * Already vendored crates > > Can I assume any crates we have already in mozilla-central are ok to

Rust crate approval

2018-06-26 Thread Adam Gashlin
ends on "widestring", which is small and has been around for a while but isn't widely used, should I have that reviewed internally as well? Is popularity a reasonable measure? Thanks! -Adam Gashlin ___ dev-platform mailing list dev-platform@l

Re: Firefox build issues with Rust and the new VS2017 15.5 update

2017-12-06 Thread Adam Gashlin
I encountered an issue building with the latest VS update, warnings treated as errors regarding TR1 deprecation, in at least some gtest files. This can be avoided by running as CXXFLAGS=-D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING ./mach build though I imagine there are better ways of adding in t