Re: Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-05 Thread Gabriele Svelto
On 05/08/19 12:04, Henri Sivonen wrote: > I has come to my attention that that putting non-header-only code > under mfbt/ is something we're trying to get away from: > https://bugzilla.mozilla.org/show_bug.cgi?id=1554062 > > Do we have an appropriate place for headers that declare entry points > f

Re: NotNull and pointer parameters that may or may not be null

2019-08-05 Thread Henri Sivonen
On Mon, Jul 22, 2019 at 10:00 AM Karl Tomlinson wrote: > Google style requires pointers for parameters that may be mutated > by the callee, which provides that the potential mutation is > visible at the call site. Pointers to `const` types are > permitted, but recommended when "input is somehow t

Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-05 Thread Henri Sivonen
I has come to my attention that that putting non-header-only code under mfbt/ is something we're trying to get away from: https://bugzilla.mozilla.org/show_bug.cgi?id=1554062 Do we have an appropriate place for headers that declare entry points for non-header-only functionality (in my case, backed

[desktop] Bugs logged by Desktop Release QA in the last 7 days

2019-08-05 Thread Mihai Boldan
Hello, Here's the list of new issues found and filed by the Desktop Release QA team in the last 7 days. Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://tinyurl.com/y6g925jx. Bugs logged by Desktop Release QA in the last

Re: PHC, a probabilistic heap checker, will soon be enabled on Linux64 Nightly

2019-08-05 Thread Nicholas Nethercote
Hi again, The enabling of PHC on Linux64 Nightly builds went smoothly, so I just enabled it for Win64 Nightly builds (bug 1569864). This will increase the number of users by roughly 10x. If you have minidump access on crash-stats you can search for PHC crash reports by searching for the presence