Re: crash reporting, inline functions, and you

2019-04-05 Thread Kartikaya Gupta
Thank you for doing this work! Any additional information for inlined frames in crash stacks will be hugely helpful. On Fri, Apr 5, 2019 at 12:34 PM Nathan Froyd wrote: > > TL;DR: We're making some changes to how inlined functions are handled > in our crash reports on non-Windows platforms in bug

Re: Intent to deprecate - linux32 tests starting with Firefox 69

2019-04-05 Thread Kartikaya Gupta
On Fri, Apr 5, 2019 at 10:45 AM Boris Zbarsky wrote: > > On 4/5/19 10:20 AM, Kartikaya Gupta wrote: > > If we can drop that then we can remove a bunch of complexity > > and code paths. > > Are we talking about just dropping linux32 _tests_, or dropping linux32 > _support_? Tests. > Because if we

Re: crash reporting, inline functions, and you

2019-04-05 Thread Calixte Denizet
Awesome and super useful work. I really hope it'll help us to detect the guilty patches. Calixte Le ven. 5 avr. 2019 à 18:34, Nathan Froyd a écrit : > TL;DR: We're making some changes to how inlined functions are handled > in our crash reports on non-Windows platforms in bug 524410. This > cha

Re: crash reporting, inline functions, and you

2019-04-05 Thread Bobby Holley
This is awesome - thank you Nathan! On Fri, Apr 5, 2019 at 9:34 AM Nathan Froyd wrote: > TL;DR: We're making some changes to how inlined functions are handled > in our crash reports on non-Windows platforms in bug 524410. This > change should mostly result in more understandable crash stacks fo

crash reporting, inline functions, and you

2019-04-05 Thread Nathan Froyd
TL;DR: We're making some changes to how inlined functions are handled in our crash reports on non-Windows platforms in bug 524410. This change should mostly result in more understandable crash stacks for code that uses lots of inlining, and shouldn't make things any worse. Some crash signatures ma

Re: Intent to deprecate - linux32 tests starting with Firefox 69

2019-04-05 Thread Boris Zbarsky
On 4/5/19 10:20 AM, Kartikaya Gupta wrote: If we can drop that then we can remove a bunch of complexity and code paths. Are we talking about just dropping linux32 _tests_, or dropping linux32 _support_? Because if we're keeping support, and linux32 is the only non-APZ confiration, then not

Re: Intent to deprecate - linux32 tests starting with Firefox 69

2019-04-05 Thread Kartikaya Gupta
I would be happy to see Linux32 (and in particular, desktop non-e10s) tests decommissioned, as that is pretty much the only configuration with APZ disabled now. If we can drop that then we can remove a bunch of complexity and code paths. On Fri., Apr. 5, 2019, 10:05 Boris Zbarsky, wrote: > On 4/

Re: Intent to deprecate - linux32 tests starting with Firefox 69

2019-04-05 Thread Boris Zbarsky
On 4/5/19 9:35 AM, jma...@mozilla.com wrote: As our next ESR is upcoming, I would like to turn off linux32 on Firefox 69 and let it ride the trains and stay on 68 ESR. This will allow builds/tests to be supported with security updates into 2021. The only thing I've used the linux32 tests for

Intent to deprecate - linux32 tests starting with Firefox 69

2019-04-05 Thread jmaher
Currently linux32 makes up about .77% of our total users. This is still 1M+ users on any given week. There is not a lot of support in the industry for 32 bit linux, all the major vendors are only distributing 64 bit versions now and other browser vendors only distribute 64 bit versions officia

git-cinnabar users, please read

2019-04-05 Thread Mike Hommey
Hi, If you are using git-cinnabar to access the Mozilla mercurial repositories, I need your help. Please take a minute to download the following file: https://gist.githubusercontent.com/glandium/a46ef0282e28b8ad2e3ecb5cca259833/raw/2ee8b8dd2c3b07226b6b967f1fb1c407c45f8862/check.py Then, from wit