Re: The upcoming C/C++ coding style change

2018-12-13 Thread Randell Jesup
>>If I'm understanding your situation correctly, I believe you can use rebase >>to update a whole queue of dependent patches, provided you have the >>format-source extension enabled. Ok. For anyone with mq patch queues, here's a sequence that should work. I hit a problem, and will file a bug on

Intent to ship: InputEvent.inputType (with Input Events Level 1)

2018-12-13 Thread Masayuki Nakano
Summary: Implement and ship InputEvent.inputType for conforming to Input Events Level 1. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1447239 Link to standard: InputEvent.inputType: https://w3c.github.io/uievents/#dom-inputevent-inputtype Value of InputEvent.inputType: Level 1: https://ra

Re: The upcoming C/C++ coding style change

2018-12-13 Thread Ehsan Akhgari
On Thu, Dec 13, 2018 at 6:05 PM Randell Jesup wrote: > >> tl;dr: I need to figure out how I'm going to dig out of the rebasing > hole > >> I'm now in, and could use advice/help, and I think the above sequence > >> doesn't work for queues of dependent patches. > > > >If I'm understanding your situ

Re: The upcoming C/C++ coding style change

2018-12-13 Thread Randell Jesup
>> tl;dr: I need to figure out how I'm going to dig out of the rebasing hole >> I'm now in, and could use advice/help, and I think the above sequence >> doesn't work for queues of dependent patches. > >If I'm understanding your situation correctly, I believe you can use rebase >to update a whole qu

Re: Upcoming changes to our C++ Coding Style

2018-12-13 Thread Ehsan Akhgari
Previously I had shied away from ideas similar to (a) or (b) since I wasn't sure if that would be what developers would expect and accept, given that it would cause the change the reviewer sees to no longer match their local change, which could cause hicups e.g. when trying to find the code that a

Re: The upcoming C/C++ coding style change

2018-12-13 Thread Jonathan Kew
On 13/12/2018 14:52, Randell Jesup wrote: But still all is not lost here. When you do decide to do the manual merging when you needed those patches, you would need to: * Update your working tree to the parent of the commit that did the reformat. * Apply your patch to that tree and reformat

Re: Disabling IPC protocol with build flags?

2018-12-13 Thread Nathan Froyd
We have PREPROCESSED_IPDL_SOURCES in moz.build, which should at least let you preprocess IPDL files before they get compiled. There are no uses in the tree, but there are tests, so ideally you should not run into *too* many issues. -Nathan On Thu, Dec 13, 2018 at 11:45 AM wrote: > >TL;DR: Is

Re: Disabling IPC protocol with build flags?

2018-12-13 Thread Tom Ritter
This would also be relevant for Tor; as they would like to disable direct UDP and TCP IPC mechanisms: https://trac.torproject.org/projects/tor/ticket/28148 -tom On Thu, Dec 13, 2018 at 4:45 PM wrote: > >TL;DR: Is there a way to make a "manages" declaration conditional, for > protocols that

Disabling IPC protocol with build flags?

2018-12-13 Thread docfaraday
TL;DR: Is there a way to make a "manages" declaration conditional, for protocols that depend on types that might not be defined for certain build-flags? I ask because I am working on a protocol that fulfills webrtc's networking needs (PMediaTransport), but webrtc can be disabled as a who

Re: The upcoming C/C++ coding style change

2018-12-13 Thread Randell Jesup
>But still all is not lost here. When you do decide to do the manual >merging when you needed those patches, you would need to: > > * Update your working tree to the parent of the commit that did the >reformat. > * Apply your patch to that tree and reformat the tree. > * Diff the reformat commi

Intent to unship: x-moz-errormessage attribute

2018-12-13 Thread Andrea Marchesini
x-moz-errormessage attribute can be used to have a custom error message when validating a form field. This is a mozilla-only attribute which was rejected in 2010 by w3: https://www.w3.org/Bugs/Public/show_bug.cgi?id=10923 Currently, a similar message can be set using setCustomValidity() method: ht