Re: Dead-code removal of unused Rust FFI exports

On Tue, Aug 28, 2018 at 4:56 PM, Till Schneidereit wrote: > On Tue, Aug 28, 2018 at 3:20 PM Mike Hommey wrote: >> We don't LTO across languages on any platform yet. Rust is LTOed on all >> platforms, which removes a bunch of its symbols. Everything that is >> exposed for C/C++ from Rust, though,

JS compilation/evaluation APIs are now in #include "js/CompilationAndEvaluation.h"

jsapi.h and jsfriendapi.h are mega-huge, monolithic headers. A one-stop shop is maybe (maybe) convenient for users. But it's terrible for Gecko and SpiderMonkey: touching jsapi.h rebuilds the world. (The one-stop shop approach is also pretty terrible for users because js*api.h are unreadable,

Re: Intent to implement and ship: WebXR Device API in Firefox Nightly

Hi David, These are all great points, thanks for reviewing this. The intent is to not allow WebXR in any iframe (not just sandboxed ones), until the discussions have settled. I appreciate the feedback on the feature policy approach and how the origin would be presented to the user. Much of th

PSA: Semantic changes to lint 'warnings'

As of bug 1460856, mozlint (the library underpinning our various lint systems) will no longer display warnings by default. All current linters which were previously emitting warnings have been changed to the 'error' level, so this won't cause any loss of coverage. There are different implications d

Re: [IMPORTANT] QA Firefox 64 feature testing pi-requests deadline is August 29

Hi, Just a reminder that the deadline to send Fx64 PI Requests is *tomorrow*. Please send your PI Requests as soon as possible. See details below. Regards, Tom On Tue, Aug 21, 2018 at 3:39 PM Tom Grabowski wrote: > Hi, > > Similar to what QA did for previous Firefox feature testing prioritiza

Re: Plan for Sunsetting MozReview

See https://bugzilla.mozilla.org/show_bug.cgi?id=1480887 for the redirect service, which is in progress. Mark On Mon, Aug 27, 2018 at 6:57 PM, Botond Ballo wrote: > > Until this gets fixed, a workaround for closed bugs is to go to the > bottom of the bug, and look for https://hg.mozilla.org/ >

Re: Dead-code removal of unused Rust FFI exports

CC'ing mw, who is working on cross-language LTO. On Tue, Aug 28, 2018 at 3:20 PM Mike Hommey wrote: > On Tue, Aug 28, 2018 at 09:14:02AM -0400, Jeff Muizelaar wrote: > > We don't LTO yet on Mac. > > We don't LTO across languages on any platform yet. Rust is LTOed on all > platforms, which remove

Re: Dead-code removal of unused Rust FFI exports

On Tue, Aug 28, 2018 at 09:14:02AM -0400, Jeff Muizelaar wrote: > We don't LTO yet on Mac. We don't LTO across languages on any platform yet. Rust is LTOed on all platforms, which removes a bunch of its symbols. Everything that is exposed for C/C++ from Rust, though, is left alone. That's likely t

Re: Dead-code removal of unused Rust FFI exports

We don't LTO yet on Mac. -Jeff On Tue, Aug 28, 2018 at 5:17 AM, Emilio Cobos Álvarez wrote: > > > On 8/28/18 9:35 AM, Henri Sivonen wrote: >> >> Does some lld mechanism successfully remove dead code when gkrust >> exports some FFI function that the rest of Gecko never ends up >> calling? > > > I

Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

On 22/08/2018 21:29, Mark Banner wrote: Since there are a large amount of instances (approx 12k) that would need to be fixed across the code base, I would propose that we roll it out on a per-directory basis. For example, we could do all of browser/ at the start of the 64 cycle just after the

Re: Dead-code removal of unused Rust FFI exports

On 8/28/18 9:35 AM, Henri Sivonen wrote: Does some lld mechanism successfully remove dead code when gkrust exports some FFI function that the rest of Gecko never ends up calling? I would expect LTO to get rid of it, but haven't checked myself. I.e. in terms of code size, is it OK to vendor

How do I inject the WebExtensions API into a ?

I'm trying to make WebExtensions usable on Thunderbird. My current problem is trying to make moz-extension:// pages work in the UI. Everything happens as expected except the page has no access to the "browser" API. Can somebody show me how to set things up so the API is added to new browse

Dead-code removal of unused Rust FFI exports

Does some lld mechanism successfully remove dead code when gkrust exports some FFI function that the rest of Gecko never ends up calling? I.e. in terms of code size, is it OK to vendor an FFI-exposing Rust crate where not every FFI function is used (at least right away)? -- Henri Sivonen hsivo..