PSA: static atom definitions have moved to xpcom/ds/StaticAtoms.py

2018-08-17 Thread Cameron McCormack
Hi everyone, Just a heads up on some changes to static atoms that I landed a couple of days. Static atom definitions now live in xpcom/ds/StaticAtoms.py. This script generates nsGkAtomList.h at build time. nsGkAtomList.h is still used by nsGkAtoms.{h,cpp} to actually define the C++ atoms and

Re: PSA: cbindgen will be required to build in the near future.

2018-08-17 Thread Jan Beich
Emilio Cobos Álvarez writes: > Hi, > > In bug 1478813 (now on inbound), I've added a new toolchain job and > code to install cbindgen[1] via `mach bootstrap`, and it will become a > hard build dependency in the near future. > > We use it on the style system to generate C++ structs / enums from th

Re: PSA: cbindgen will be required to build in the near future.

2018-08-17 Thread Emilio Cobos Álvarez
On 8/17/18 2:53 PM, Xidorn Quan wrote: I'm actually thinking about pulling bindgen out from build-dependency and make it use binary as well. bindgen was made a build-dependency and build in the process because at that time, bindgen wasn't stable enough, and we usually need to fix it for stylo

Re: PSA: cbindgen will be required to build in the near future.

2018-08-17 Thread Xidorn Quan
On Fri, Aug 17, 2018, at 10:19 PM, Emilio Cobos Álvarez wrote: > Adding support for general crates.io crates to be built this way and > appear somewhere on the objdir seemed way more build system hackery than > what I could do in a reasonable timeframe with my limited knowledge of > the build sy

Re: PSA: cbindgen will be required to build in the near future.

2018-08-17 Thread Emilio Cobos Álvarez
On 8/17/18 1:37 PM, Jan Beich wrote: Emilio Cobos Álvarez writes: Hi, In bug 1478813 (now on inbound), I've added a new toolchain job and code to install cbindgen[1] via `mach bootstrap`, and it will become a hard build dependency in the near future. We use it on the style system to generate

Re: Workaround for building with Visual Studio 15.7+

2018-08-17 Thread Frank-Rainer Grahl
15.8 finally fixed the compiler bug and starting with preview 4 I also got a good executable out. Had problems here with preview 3. 15.8 needs a configure fix for _RAISE. Only compiled the comm-esr52 tree with backports to support VS2017 and comm-esr60 right now. Only x64 too. FRG Jeff Gil

PSA: mercurial-setup becomes vcs-setup and adds support for git

2018-08-17 Thread Panos Astithas
Hi all, since bug 1257478 landed in m-c earlier today, you should now be using 'mach vcs-setup' instead of 'mach mercurial-setup'. Nothing else changes in your workflow (e.g. 'mach mercurial-setup -u' becomes 'mach vcs-setup -u') and the spell checker will suggest vcs-setup if you try to use mercu