Re: overly strict eslint rules

2017-12-24 Thread Masatoshi Kimura
On 2017/12/25 6:31, Jonathan Kingston wrote: > It has worked for me for quite some time just running ./mach lint > filename.js after bootstrap. I got the following error when I tried it just now: --- $ mach lint browser/base/content/abo

Re: overly strict eslint rules

2017-12-24 Thread Jonathan Kingston
I'm not sure on the exact rule that was failing. However having failed code reviews that would pass in one part of the codebase can be pretty frustrating. I would rather stylistic errors come from automated tests and such that checking of algos and so on can be focused on in a code review. Firefox

overly strict eslint rules

2017-12-24 Thread Ben Kelly
Hello, First let me say, I don't like participating in style discussions on the list. I don't think they are productive in general and I don't want to have one of those threads here. I feel I need to raise as an issue, though, as eslint rules are being pushed out into components with what seem l

Re: Intent to implement: support CSS paint-order for HTML text

2017-12-24 Thread James Graham
On 24/12/2017 13:13, Emilio Cobos Álvarez wrote: On 12/24/2017 02:01 PM, Jonathan Kew wrote: Tests - Is this feature fully tested by web-platform-tests? No, as it is not yet spec'd (see above). I propose to land a basic mozilla reftest along with the patches in bug 1426146 (behind a pref); if/wh

Re: Intent to implement: support CSS paint-order for HTML text

2017-12-24 Thread Emilio Cobos Álvarez
On 12/24/2017 02:01 PM, Jonathan Kew wrote: > Tests - Is this feature fully tested by web-platform-tests? No, as it is > not yet spec'd (see above). I propose to land a basic mozilla reftest > along with the patches in bug 1426146 (behind a pref); if/when the CSS > WG agrees to accept this issue in

Intent to implement: support CSS paint-order for HTML text

2017-12-24 Thread Jonathan Kew
Summary: For text that is stroked as well as filled (using -webkit-text-stroke), this allows the author to control whether the stroke is painted before or after the fill. The current behavior is to always paint the stroke on top, which is often visually poor, and leads authors to use cumbersome