Intent to ship: New default action, horizontal scroll, of wheel with Shift key (except Firefox for macOS)

2017-10-17 Thread Masayuki Nakano
From some users who use legacy mice which supports only vertical wheel, we have a request to support horizontal scroll with vertical wheel operation with a modifier. https://bugzilla.mozilla.org/show_bug.cgi?id=143038 Now, legacy add-ons have gone since 57 and it may be difficult to override d

Re: Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Boris Zbarsky
On 10/17/17 8:12 PM, Myk Melez wrote: Shouldn't the code rather move to comm-central if it's specific to mailnews? That would be fine too, yes. -Boris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev

Re: Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Myk Melez
Boris Zbarsky 2017 October 17 at 07:45 Please double-check that this use case does not get broken, or condition the code to be mailnews-only or something. Shouldn't the code rather move to comm-central if it's specific to mailnews? -myk ___

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread Andrew Halberstadt
On Tue, Oct 17, 2017 at 4:00 PM wrote: > Those things can be encoded as regexps, but they span across programming > languages (XUL, XHTML, HTML, XBL, DTD, JS, C++). > To create a new regex-based linter, simply add a file like this: https://dxr.mozilla.org/mozilla-central/source/tools/lint/test-d

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread Gregory Szorc
On Tue, Oct 17, 2017 at 9:58 PM, wrote: > This is awesome! As an engineer who has to work with C++ until we advance > Rust bindings, I always feel terrible when my reviewers spend their > precious time identifying simple C++ errors in my code. > > > Seeing the advancements in static analysis for

Re: Intent to ship: (hyperlink auditing)

2017-10-17 Thread James Graham
On 02/10/17 18:06, Anne van Kesteren wrote: Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=951104 Rationale: There's already a myriad of ways to obtain this data through script. We might as well ship the protocol that both Chrome and Safari ship in the hope that along with sendBeacon() it dec

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread zbraniecki
This is awesome! As an engineer who has to work with C++ until we advance Rust bindings, I always feel terrible when my reviewers spend their precious time identifying simple C++ errors in my code. Seeing the advancements in static analysis for C++, rustfmt and eslint for JS, I'm wondering if

Re: Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Boris Zbarsky
On 10/17/17 5:47 AM, Shih-Chiang Chien wrote: I intent to remove all the code that handling BinHex decoding, i.e. nsBinHex.cpp, from mozilla-central if no other project is using it. The code was originally added for mailnews. See https://bugzilla.mozilla.org/show_bug.cgi?id=81352 Please dou

Intent to Unship: stream decoder for BinHex format

2017-10-17 Thread Shih-Chiang Chien
Currently on non-Mac platform, firefox will decompression the content while loading resource with MIME type "application/mac-binhex40". This introduces the confusion like bug 1390708 when Firefox trying to decode BinHex file. On Mac platform we already disabled stream decoding of BinHex file. I te

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread Jan Keromnes
Thanks glandium! Yes, reporting defects that are expanded from macros generates a lot of noise, and it's not always an issue we can fix (e.g. when the macro comes from third-party code). So we've decided to stop reporting these, and the fix was merged in time for tomorrow's push to production. TL

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread Mike Hommey
On Tue, Oct 17, 2017 at 10:38:09AM +0200, Jean-Yves Avenard wrote: > Hi > > Do you have ways to prevent running this code on some external > frameworks? > > Whenever we modify a gtest this causes hundreds of errors about not > using a default constructor … (which shouldn’t be an error anyway) ht

Re: Intent to Enable: Automated Static Analysis feedback in MozReview

2017-10-17 Thread Jean-Yves Avenard
Hi Do you have ways to prevent running this code on some external frameworks? Whenever we modify a gtest this causes hundreds of errors about not using a default constructor … (which shouldn’t be an error anyway) > On 9 Oct 2017, at 4:33 pm, Jan Keromnes wrote: > > > C/C++ was our top priori