Re: Coding style: Argument alignment

2017-09-09 Thread Mats Palmgren
On 8/31/17 6:50 PM, Ehsan Akhgari wrote: On 08/30/2017 09:03 PM, Eric Rahm wrote: Okay sounds like there's agreement on a). Indeed.  I have edited the Style Guide to reflect this. Fwiw, I disagree with this decision. Here's a more realistic example of *actual use* from our code base: http:/

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-09 Thread Sylvestre Ledru
Le 08/09/2017 à 02:24, Martin Thomson a écrit : > On Fri, Sep 8, 2017 at 1:08 AM, Ehsan Akhgari wrote: >> The great majority of code changing is quite expected for any project >> switching to clang-format, since as it turns out automated tools are much >> better at doing this grunt work than human

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-09 Thread Mats Palmgren
On 9/7/17 4:45 PM, Ehsan Akhgari wrote: $ git grep '\s(>|>=|<|<=|==|!=)\s*$' -- '*.c*' | wc -l 2794 Don't you get plenty of false positives for '>' with that regexp though? For example: dom/bindings/BindingUtils.h:template js/public/HashTable.h:struct IsPod > etc /Mats