Re: New [must_use] property in XPIDL

2016-08-25 Thread Nicholas Nethercote
On Thu, Aug 25, 2016 at 10:33 PM, Gijs Kruitbosch wrote: > > Sorry, I'm not being very clear, I'm afraid. I'm not asking to ditch > nsresult. > > I'm wondering if we can make a "smarter" annotation than [must_use] that > requires *either* a nullcheck on the outparam or an nsresult check (rather >

Re: New [must_use] property in XPIDL

2016-08-25 Thread Nicholas Nethercote
On Fri, Aug 26, 2016 at 3:31 AM, ISHIKAWA,chiaki wrote: > > There ought to be a long-term plan for C-C and M-C to introduce such missing > checks gradually. That's exactly what I'm trying to do with MOZ_MUST_USE/[must_use]. Bug 1268766 is the tracking bug. There's a lot of work to be done. Much

Re: Alternative to Bonsai?

2016-08-25 Thread Boris Zbarsky
On 8/25/16 3:22 PM, Andrew McCreight wrote: Searchfox works pretty well for blame including the CVS history, including large files that github won't show you. The point is in this case the CVS history has a single crash-landing, unless you look at the (different) aviary branch CVS repo. -Bor

Re: Alternative to Bonsai?

2016-08-25 Thread Andrew McCreight
Searchfox works pretty well for blame including the CVS history, including large files that github won't show you. On Thu, Aug 25, 2016 at 12:09 PM, Philip Chee wrote: > On 16/09/2015 01:01, smaug wrote: > > On 09/15/2015 06:53 PM, Boris Zbarsky wrote: > >> On 9/15/15 11:11 AM, Ben Hearsum wrote

Re: Alternative to Bonsai?

2016-08-25 Thread Philip Chee
On 16/09/2015 01:01, smaug wrote: > On 09/15/2015 06:53 PM, Boris Zbarsky wrote: >> On 9/15/15 11:11 AM, Ben Hearsum wrote: >>> I'm pretty sure https://github.com/mozilla/gecko-dev has full >>> history. >> >> Though note that it doesn't have working blame for a lot of files >> in our source tree (

Re: Heads up: valgrind/memcheck issues

2016-08-25 Thread ISHIKAWA,chiaki
Hi, I did at least for the memory access after free issue. Other issues may have to wait unless someone checks the issues. I wish these are false positives, but they seem too numerous this time around. TIA CI On 2016/08/26 3:17, Andrew McCreight wrote: We regularly run AddressSanitizer and

Re: Heads up: valgrind/memcheck issues

2016-08-25 Thread Andrew McCreight
We regularly run AddressSanitizer and Valgrind on mozilla-central, so it seems likely this is Thunderbird specific. Please file security bugs in bugzilla with any reports you have found. Andrew On Thu, Aug 25, 2016 at 10:59 AM, ISHIKAWA,chiaki wrote: > Hi, > > I occasionally check C-C TB by run

Heads up: valgrind/memcheck issues

2016-08-25 Thread ISHIKAWA,chiaki
Hi, I occasionally check C-C TB by running |make mozmill| test suite under valgrind/memcheck for detecting memory issues. I ran such a test the day before and saw a flurry of memcheck warnings which I did not see in the test that was run back on May 12th. So in three months between, some

Re: New [must_use] property in XPIDL

2016-08-25 Thread ISHIKAWA,chiaki
On 2016/08/25 6:38, Mike Hommey wrote: On Mon, Aug 22, 2016 at 04:39:15PM -0700, R Kent James wrote: On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: I strongly encourage people to do likewise on any IDL files with which they are familiar. Adding appropriate checks isn't always easy Exactly,

Re: Rationalising Linux audio backend support

2016-08-25 Thread Randell Jesup
>I just landed some telemetry to measure the usage of all audio backends, >we'll have data soon. > >This was bug 1280630, and the probe is at [0]. This also measures >failures to open a stream and usage of backends that should not be used >on certain platform, like winmm on windows vista+. > >Als

Re: New [must_use] property in XPIDL

2016-08-25 Thread Gijs Kruitbosch
On 25/08/2016 06:14, Nicholas Nethercote wrote: On Wed, Aug 24, 2016 at 9:38 PM, Gijs Kruitbosch wrote: I'm mostly in frontend Firefox land so excuse the potentially dumb question and probably incorrect terminology... My impression was that we already have things like NonNull, and if we are now