Re: New [must_use] property in XPIDL

2016-08-22 Thread R Kent James
On 8/22/2016 9:28 PM, Nicholas Nethercote wrote: > On Tue, Aug 23, 2016 at 9:39 AM, R Kent James wrote: >> On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: >>> I strongly encourage people to do likewise on >>> any IDL files with which they are familiar. Adding appropriate checks isn't >>> always e

Re: New [must_use] property in XPIDL

2016-08-22 Thread Nicholas Nethercote
On Mon, Aug 22, 2016 at 2:14 PM, Nicholas Nethercote wrote: > > If you file a bug to add [must_use] or MOZ_MUST_USE somewhere, please make the > bug block the tracking bug Some recent work on this front: - Jan Varga used [must_use] in nsIQuota{ManagerService,Requests}.idl: https://bugzilla.mozil

Re: New [must_use] property in XPIDL

2016-08-22 Thread Nicholas Nethercote
On Tue, Aug 23, 2016 at 9:39 AM, R Kent James wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: >> I strongly encourage people to do likewise on >> any IDL files with which they are familiar. Adding appropriate checks isn't >> always easy > > Exactly, and I hope that you and others restrai

Re: New [must_use] property in XPIDL

2016-08-22 Thread Nathan Froyd
On Mon, Aug 22, 2016 at 7:39 PM, R Kent James wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: >> I strongly encourage people to do likewise on >> any IDL files with which they are familiar. Adding appropriate checks isn't >> always easy > > Exactly, and I hope that you and others restrai

Re: New [must_use] property in XPIDL

2016-08-22 Thread Nick Fitzgerald
On Mon, Aug 22, 2016 at 4:39 PM, R Kent James wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: > > I strongly encourage people to do likewise on > > any IDL files with which they are familiar. Adding appropriate checks > isn't > > always easy > > Exactly, and I hope that you and others r

Re: New [must_use] property in XPIDL

2016-08-22 Thread Bobby Holley
On Mon, Aug 22, 2016 at 4:39 PM, R Kent James wrote: > On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: > > I strongly encourage people to do likewise on > > any IDL files with which they are familiar. Adding appropriate checks > isn't > > always easy > > Exactly, and I hope that you and others r

Re: New [must_use] property in XPIDL

2016-08-22 Thread R Kent James
On 8/21/2016 9:14 PM, Nicholas Nethercote wrote: > I strongly encourage people to do likewise on > any IDL files with which they are familiar. Adding appropriate checks isn't > always easy Exactly, and I hope that you and others restrain your exuberance a little bit for this reason. A warning woul

Intent to ship imageSmoothingEnabled and remove mozImageSmoothingEnabled.

2016-08-22 Thread Thomas Wisniewski
Summary: ctx.imageSmoothingEnabled is a Canvas2D context property controlling the interpolation of images drawn to 2D canvases (especially useful for pixel art). Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=768072 Link to standard: https://html.spec.whatwg.org/multipage/scripting.html#image-

Intent to deprecate: Building mozilla-central without Skia enabled

2016-08-22 Thread George Wright
I'm looking to remove the option to build mozilla-central without Skia. Currently we default to Skia being disabled, and enable it using --enable-skia. This is problematic because all of our officially supported build configurations enable Skia, and as such the Skia-is-disabled build has been

Re: Intent to implement and ship: SVGElement.prototype.dataset

2016-08-22 Thread Boris Zbarsky
On 8/15/16 1:57 PM, Aryeh Gregor wrote: Why doesn't this just go on Element, like .className and .id? If you think it should, and can convince Blink and Edge to do that, we could do it from a technical point of view. From a theoretical point of view, it doesn't seem like as generic a concep

Re: Intent to unship: WorkerGlobalScope.onclose

2016-08-22 Thread Ms2ger
On 22/08/16 10:03, Andrea Marchesini wrote: > I'm planning to remove |partial interface WorkerGlobalScope { attribute > EventHandler onclose; }|. > This EventHandler has been in our code base since ever but it's not part of > the Workers spec and no other browses implement it. > > In order to be

[Firefox Desktop] Issues found: August 15th to August 19th

2016-08-22 Thread Cornel Ionce
Hi everyone, Here's the list of new issues found and filed by the Desktop Release QA Team last week, *August 15 - August 19* (week 33). Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://public.etherpad-mozilla.org/

Intent to unship: WorkerGlobalScope.onclose

2016-08-22 Thread Andrea Marchesini
I'm planning to remove |partial interface WorkerGlobalScope { attribute EventHandler onclose; }|. This EventHandler has been in our code base since ever but it's not part of the Workers spec and no other browses implement it. In order to be compliant the spec, it's time to get rid of this. Any ob