Checkin-needed requests - Please include complete information in the commit message :)

2016-07-07 Thread Carsten Book
Hi, someone might not know that doing checkins for checkin-needed request is not automated yet and completely a fully human task :) (no we Sheriffs are not bots ;) It would help us a lot if a checkin needed request would contain complete Author/Patch information like: - Author (use the infor

Re: Static analysis for "use-after-move"?

2016-07-07 Thread Jim Blandy
Yes, that's part of the standard expectations for std::move, and thus mozilla::Move as well. On Thu, Jul 7, 2016 at 6:53 AM, Gerald Squelart wrote: > On Monday, May 2, 2016 at 9:49:24 AM UTC+10, Jim Blandy wrote: > > No, we don't know that [moved-from strings become empty]. > > The contract of

Re: MXR permanently offline, please transition to DXR

2016-07-07 Thread Peter Elmers
If it helps anyone, I happen to know that there exists an addon which visits all anchor tags on a page and rewrites mxr.mozilla.org to dxr.mozilla.org. https://addons.mozilla.org/en-US/firefox/addon/mxr-to-dxr/ Disclaimer: I'm the author. On Wed, Jul 6, 2016 at 7:12 PM, Boris Zbarsky wrote: > O

Re: Static analysis for "use-after-move"?

2016-07-07 Thread Gerald Squelart
On Monday, May 2, 2016 at 9:49:24 AM UTC+10, Jim Blandy wrote: > No, we don't know that [moved-from strings become empty]. > The contract of a move in C++ is simply that the > source object is safe to destruct, but otherwise in an undefined state*. You > must not make any assumptions about its valu

Re: Redesigning the docshell/loadgroup/document interaction

2016-07-07 Thread Boris Zbarsky
On 7/7/16 6:33 AM, Anne van Kesteren wrote: On Fri, May 20, 2016 at 4:56 PM, Boris Zbarsky wrote: 2) Create the loadgroup when we're starting the document request. The channel would just keep it alive while it's active; if we end up creating a document, the document can grab it from the chann

Re: DXR problem?

2016-07-07 Thread Richard Z
On Wed, Jul 06, 2016 at 11:11:40AM -0400, Erik Rose wrote: > I get a underline on hover, plus my cursor changes to the "context-menu" one. > What happens for you? absolutely nothing. The console displays only some nunjucks warning - is this relevant? "[nunjucks] Warning: the "default" filter wa

Re: Redesigning the docshell/loadgroup/document interaction

2016-07-07 Thread Anne van Kesteren
On Fri, May 20, 2016 at 4:56 PM, Boris Zbarsky wrote: > 2) Create the loadgroup when we're starting the document request. The > channel would just keep it alive while it's active; if we end up creating a > document, the document can grab it from the channel and store it. This > might just work

Re: Treeherder, Task Cluster and Pulse

2016-07-07 Thread Selena Deckelmann
πŸ•ΆπŸ‘–πŸ» Thanks all for making this happen and special thanks for a delightful change summary, Cam! -Selena On Wed, Jul 6, 2016 at 4:43 PM Cameron Dawson wrote: > Tomorrow morning we will be changing how Treeherder gets data from Task > Cluster. > > tl;dr β€” No action required on your part. We are c