Re: Coding style for C++ enums

2016-04-10 Thread smaug
On 04/10/2016 05:50 PM, Aryeh Gregor wrote: On Fri, Apr 8, 2016 at 8:35 PM, smaug wrote: enum classes are great, but I'd still use prefix for the values. Otherwise the values look like types - nested classes or such. (Keeping my reviewer's hat on, so thinking about readability here.) In some

Re: Coding style for C++ enums

2016-04-10 Thread Aryeh Gregor
On Fri, Apr 8, 2016 at 8:35 PM, smaug wrote: > enum classes are great, but I'd still use prefix for the values. Otherwise > the values look like types - nested classes or such. > (Keeping my reviewer's hat on, so thinking about readability here.) In some cases I think it's extremely clear, like