Re: Proposal to stop revving UUIDs when changing XPIDL interfaces

2016-01-28 Thread Ehsan Akhgari
On 2016-01-28 7:24 PM, Eric Rahm wrote: Have the reject-on-idl-change-but-no-uuid-change scripts been updated on the hg server? Yes (on m-c and branches that merge to it.) ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mo

Re: Proposal to stop revving UUIDs when changing XPIDL interfaces

2016-01-28 Thread Eric Rahm
On Thursday, January 28, 2016 at 2:56:19 PM UTC-8, Ehsan Akhgari wrote: > 10 days and no objections. This is now the new rule! Please stop updating > UUIDs when changing XPIDL interfaces. > > On Fri, Jan 15, 2016 at 10:58 AM, Ehsan Akhgari > wrote: > > > Historically we have enforced updating

Re: Just Autoland It

2016-01-28 Thread Eric Rescorla
On Thu, Jan 28, 2016 at 10:58 AM, Gregory Szorc wrote: > I'd like to thank everyone for the feedback in this thread. However, the > thread has grown quite long and has detoured from its original subject. > > Speaking on behalf of everyone who works on MozReview, we know the > interface is lacking

Status of the Component Owners for Bug Decisions List Thursday 1/28

2016-01-28 Thread Emma Humphries
*Status of The Component Owners Sheet* https://docs.google.com/spreadsheets/d/10i30CFUPJM7snz0xX3czFJeBh2tNwjwjtI409DQw3x0/ If you have questions, @emceeaich on irc.mozilla.org If you think someone is a component owner enter 'name?' in owner column If you think a component is defunct (no longer

Re: Proposal to stop revving UUIDs when changing XPIDL interfaces

2016-01-28 Thread Ehsan Akhgari
10 days and no objections. This is now the new rule! Please stop updating UUIDs when changing XPIDL interfaces. On Fri, Jan 15, 2016 at 10:58 AM, Ehsan Akhgari wrote: > Historically we have enforced updating the XPIDL interface UUIDs when you > made any changes to it. This was needed because

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Bill McCloskey
On Thu, Jan 28, 2016 at 10:16 AM, Mike Conley wrote: > Add-ons that are not yet marked multi-process compatible will use our > shimming layer, which allows usage of unsafe CPOWs within add-on code / > compartments. > > At least part of the problem here appears to be that FireGestures has > "multi

Shutting try extender off (please add jobs through Treeherder)

2016-01-28 Thread Armen Zambrano G.
I'm going to be shutting off try-extender [1] on February 5th since you can accomplish the same via Treeherder ('add new jobs' button). I've fixed all known bugs and I have bandwidth to help in case new issues arise. In the future, more features will come to give you proper feedback when things

Re: Just Autoland It

2016-01-28 Thread Gregory Szorc
I'd like to thank everyone for the feedback in this thread. However, the thread has grown quite long and has detoured from its original subject. Speaking on behalf of everyone who works on MozReview, we know the interface is lacking in areas and features are confusing or non-existent. We're work

Does SSE2 usage still need to be conditional?

2016-01-28 Thread Henri Sivonen
It's been a while since the previous SSE2 thread. I have some questions: * Does Firefox (for Windows and Linux) still run on non-SSE2 hardware? * If it does, do the usage statistics justify it continuing to do so? * Do Linux distros that ship Firefox by default run on non-SSE2 hardware? * Do w

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Mike Conley
Add-ons that are not yet marked multi-process compatible will use our shimming layer, which allows usage of unsafe CPOWs within add-on code / compartments. At least part of the problem here appears to be that FireGestures has "multiprocessCompatible" set to true in its install.rdf: https://github

Re: Just Autoland It

2016-01-28 Thread Eric Rescorla
On Thu, Jan 28, 2016 at 8:25 AM, Honza Bambas wrote: > On 1/28/2016 6:30, Karl Tomlinson wrote: > >> Honza Bambas writes: >> >> On 1/25/2016 20:23, Steve Fink wrote: >>> For navigation, there's a list of changed files at the top (below the fixed summary pane) that jumps to per-file anch

Re: Requiring a try job prior to autolanding to inbound

2016-01-28 Thread Jed Davis
Adam Roach writes: > My understanding is that the autolander is available only to > developers with Level 3 access, right? Given that this is the same > group of people who can do a manual check-in, I don't see why we would > make autolanding have to clear a higher bar than manual landing. We co

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Dave Townsend
I don't think that this is meant to impact add-on code at all, unless it is calling browser code and making it do something unsafe, in which case it would be up to the add-on developer to fix that. It's probably worth filing a bug to track what is going on there though. On Thu, Jan 28, 2016 at 6:3

Flexbox + img aspect ratio

2016-01-28 Thread Amit Zur
I'm seeing an aberration in behaviour of img as a flex-item. Not sure what is the reason, but the img doesn't preserve aspect ratio, as seen in this fiddle: https://jsfiddle.net/dfpj6fag/6/ I saw this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=972595 but I can't understand if it's related

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Honza Bambas
Do we have any agenda for extensions? I'm using FireGestures and it's broken since this has landed, just shouting out a lot of "unsafe CPOW usage" (missing the "forbidden" tho). Is the action here limited to just file a bug on the add-on side to fix this or can we do anything on our side? (I

Re: Just Autoland It

2016-01-28 Thread Honza Bambas
On 1/28/2016 6:30, Karl Tomlinson wrote: Honza Bambas writes: On 1/25/2016 20:23, Steve Fink wrote: For navigation, there's a list of changed files at the top (below the fixed summary pane) that jumps to per-file anchors. Not good enough for review process. Are you saying you want tabs or s

Re: Just Autoland It

2016-01-28 Thread Eric Rescorla
Thanks for pointing these out. Mozreview crowd: is there any chance we can get these to be customizable? Unfortunately, I see that they directly conflict with the ones Rietveld uses but with some overlapping and some different meanings. -Ekr On Wed, Jan 27, 2016 at 9:30 PM, Karl Tomlinson wro