Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-09 Thread Jeff Gilbert
On Wed, Jul 8, 2015 at 7:48 AM, smaug wrote: > Another example where aFoo tends to be rather useful is lifetime > management. > If I see aFoo being used somewhere in a method after some unsafe method > call > (layout flush, any script callback handling, event dispatch, observer > service notifica

Re: Busy indicator API

2015-07-09 Thread Eric Shepherd
Jonas Sicking wrote: > window.navigator.addBusyTask(promise); > > would be great. The API can be called any time and any number of > times. The API would run the spinner until all provided promises are > resolved. So if it's called twice with different promises, the spinner > doesn't stop when one

Re: Should the entire JS structure be Object.freeze()'d if it's exposed through a read only property?

2015-07-09 Thread Boris Zbarsky
On 7/9/15 4:48 AM, Tim Guan-tin Chien wrote: In this case, I modified the manifest object passed from mozApp API, and the object was subsequently removed by the platform, so did my modifications. Fabrice said I should not be modified the object since it's marked as read only in WebIDL. "readonl

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-09 Thread Seth Fowler
> On Jul 8, 2015, at 8:34 AM, Michael Layzell wrote: > > We're already working on a static analysis in > https://bugzilla.mozilla.org/show_bug.cgi?id=1180993 which will prevent code > like that from passing try. > > Hopefully that will help with your concerns. Yes, that will solve the proble

Should the entire JS structure be Object.freeze()'d if it's exposed through a read only property?

2015-07-09 Thread Tim Guan-tin Chien
Hi, I want to call out on a confusion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1176184#c12 In this case, I modified the manifest object passed from mozApp API, and the object was subsequently removed by the platform, so did my modifications. Fabrice said I should not be modified the ob