Re: PSA: The mochitest ise() function is dead, please use is() instead

2015-05-13 Thread Boris Zbarsky
On 5/13/15 7:35 PM, Gregory Szorc wrote: I would steer people in the direction of Assert.jsm, specifically Assert.deepEqual This should be used very very carefully. As a very simple example, using this (or worse yet notDeepEqual) in any test that tries to check for equality of Window objects

Re: Replacing Mozmill driven tests for Firefox with Marionette

2015-05-13 Thread ISHIKAWA, Chiaki
On 2015/05/13 23:24, Andrew Halberstadt wrote:> I don't believe marionette currently works on Thunderbird, but that's > most likely due to hardcoded assumptions than any deep technical > reasons. It could probably be made to work with a little bit of effort, > it's just that to date, no one has t

Re: Replacing Mozmill driven tests for Firefox with Marionette

2015-05-13 Thread ISHIKAWA, Chiaki
Ouch, there was a line near the end. Successfully installed jsbridge-2.4.14 mozmill-1.5.16 This is from a local C-C TB build. CI ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: PSA: The mochitest ise() function is dead, please use is() instead

2015-05-13 Thread Martin Thomson
On Wed, May 13, 2015 at 4:54 PM, Matthew N. wrote: > "In JavaScript, == is preferred to ===." from > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Operators Ahh, that's where it was hiding. Can we reverse that statement please? ___

Re: PSA: The mochitest ise() function is dead, please use is() instead

2015-05-13 Thread Gregory Szorc
On Wed, May 13, 2015 at 3:52 PM, Martin Thomson wrote: > On Wed, May 13, 2015 at 3:46 PM, Ehsan Akhgari > wrote: > > ise() was an alias to is() as of bug 949614. I landed bug 1154275 on > > inbound today which removes ise() and replaces its usages with is(). > Since > > is() now does a === comp

PSA: PR_LOGGING is dead, please stop using it

2015-05-13 Thread Eric Rahm
Way back yonder in September we enabled logging by default on all builds. The world did not end. The |--disable-logging| flag remained which in theory, does in fact disable logging but none of our default builds use it, and unsurprisingly we occasionally started breaking custom builds that attem

Re: PSA: The mochitest ise() function is dead, please use is() instead

2015-05-13 Thread Martin Thomson
On Wed, May 13, 2015 at 3:46 PM, Ehsan Akhgari wrote: > ise() was an alias to is() as of bug 949614. I landed bug 1154275 on > inbound today which removes ise() and replaces its usages with is(). Since > is() now does a === comparison by default, there should be no reason to use > ise(). \o/ I

PSA: The mochitest ise() function is dead, please use is() instead

2015-05-13 Thread Ehsan Akhgari
ise() was an alias to is() as of bug 949614. I landed bug 1154275 on inbound today which removes ise() and replaces its usages with is(). Since is() now does a === comparison by default, there should be no reason to use ise(). Cheers, -- Ehsan ___ dev

Re: Intent to remove: mochitest- mach commands

2015-05-13 Thread Gregory Szorc
On Wed, May 13, 2015 at 2:03 PM, Ms2ger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/13/2015 09:54 PM, Andrew Halberstadt wrote: > > As mentioned previously in another post, work is under way to > > remove the flavor specific mochitest commands (e.g mach > > mochitest-plain,

Re: Intent to remove: mochitest- mach commands

2015-05-13 Thread Ms2ger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/13/2015 09:54 PM, Andrew Halberstadt wrote: > As mentioned previously in another post, work is under way to > remove the flavor specific mochitest commands (e.g mach > mochitest-plain, mach mochitest-browser etc.). > Does this include `mochites

Re: Intent to remove: mochitest- mach commands

2015-05-13 Thread Andrew Halberstadt
On 13/05/15 04:13 PM, Brian Grinstead wrote: Does this include subsuites like devtools? There is currently a bug on file in which `mach mochitest` doesn’t work with devtools tests (1122590). Until that is resolved, if mochitest-devtools was removed then running these tests would become the hard

Re: Intent to remove: mochitest- mach commands

2015-05-13 Thread Brian Grinstead
Does this include subsuites like devtools? There is currently a bug on file in which `mach mochitest` doesn’t work with devtools tests (1122590). Until that is resolved, if mochitest-devtools was removed then running these tests would become the harder-to-remember `./mach mochitest browser/dev

Intent to remove: mochitest- mach commands

2015-05-13 Thread Andrew Halberstadt
As mentioned previously in another post, work is under way to remove the flavor specific mochitest commands (e.g mach mochitest-plain, mach mochitest-browser etc.). This is being tracked in bug 1164597 [1]. Bug description pasted below: As part of an effort to make running tests as easy and intu

If you run mozharness on your local machine (tooltool changes)

2015-05-13 Thread Armen Zambrano G.
Hello all, At the end of last year we made some changes to make mozharness more easy to run outside of the Release Engineering VPN. Mozharness is the python harness that runs most jobs that show up on Treeherder. Tooltool has been re-written recently [1], you will now need a token on your machine

Re: Replacing Mozmill driven tests for Firefox with Marionette

2015-05-13 Thread Andrew Halberstadt
I don't believe marionette currently works on Thunderbird, but that's most likely due to hardcoded assumptions than any deep technical reasons. It could probably be made to work with a little bit of effort, it's just that to date, no one has tried. I thought thunderbird was using a very out-of

Re: Replacing Mozmill driven tests for Firefox with Marionette

2015-05-13 Thread Andreas Tolfsen
On 13 May 2015, at 04:40, Philip Chee wrote: > On 12/05/2015 20:23, Henrik Skupin wrote: >> To being able to better spread work around we basically >> have chosen the wider known Marionette framework. > > Thunderbird currently uses mozmill. Will Marionette[1] be available for > Thunderbird? Is th

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-05-13 Thread Benjamin Smedberg
I think it's time I made an official decision here. I think Ehsan's proposal makes a lot of sense both as good engineering and because we know Google has already proved it for us. I approve. Ehsan, will you please make the necessary changes to our style guide? --BDS On Mon, Apr 27, 2015 at 3:48