Re: Intent to implement and ship: Settable .files attribute on HTMLInputElement

On 4/10/15 10:15 PM, Boris Zbarsky wrote: I'm more worried about internal C++ consumers, honestly. Have to audit them all to make sure they're not assuming they can get a filename and such. For example, HTMLInputElement::GetValueInternal or HTMLInputElement::AfterSetFiles will do mFiles[0]->G

Re: Intent to implement and ship: Settable .files attribute on HTMLInputElement

On 4/10/15 7:43 PM, Jonas Sicking wrote: One option is to make the xpidl interface always return a File, but make the .webidl interface return files or blobs. Why, exactly? If we want to do this, just have them both return a Blob in terms of the IDL. If it happens to be a Blob that's also a

Re: Proposal to ban the usage of refcounted objects inside C++ lambdas in Gecko

On Fri, Apr 10, 2015 at 11:46 AM, Ehsan Akhgari wrote: > I would like to propose that we should ban the usage of refcounted objects > inside lambdas in Gecko. Here is the reason: > > Consider the following code: > > nsINode* myNode; > TakeLambda([&]() { > myNode->Foo(); > }); > > There is noth

Re: Intent to implement and ship: Settable .files attribute on HTMLInputElement

On Fri, Apr 10, 2015 at 4:31 PM, Boris Zbarsky wrote: > On 4/10/15 6:23 PM, Jonas Sicking wrote: >> >> Is there a reason to upgrade to File? > > Yes. FileList claims to return Files. > > We could change that to have it return Blobs, of course, and then make sure > that various consumers (at least

Re: Intent to implement and ship: Settable .files attribute on HTMLInputElement

On 4/10/15 6:23 PM, Jonas Sicking wrote: Is there a reason to upgrade to File? Yes. FileList claims to return Files. We could change that to have it return Blobs, of course, and then make sure that various consumers (at least the internal ones) can deal. -Boris

Re: Intent to implement and ship: Settable .files attribute on HTMLInputElement

On Fri, Apr 10, 2015 at 11:24 AM, Boris Zbarsky wrote: > 1) The setter treats its single argument as a sequence. Any Blobs > that are not already Files get upgraded to Files, identical to how > https://xhr.spec.whatwg.org/#create-an-entry behaves. Is there a reason to upgrade to File? I thought

Firefox/Platform Engineering Update 39.3

This engineering update is also available on the Platform wiki and my blog: https://wiki.mozilla.org/Platform/2015-04-14 http://cpeterso.com/blog/02015/04/mozilla-engineering-update-39-3/ # Firefox Release Schedule (lmandel) - We shipped a Firefox 37.0.1 desktop and mobile chemspills last week

Re: Proposal to ban the usage of refcounted objects inside C++ lambdas in Gecko

On 04/10/2015 09:09 PM, Seth Fowler wrote: On Apr 10, 2015, at 8:46 AM, Ehsan Akhgari wrote: I would like to propose that we should ban the usage of refcounted objects inside lambdas in Gecko. Here is the reason: Consider the following code: nsINode* myNode; TakeLambda([&]() { myNode->Fo

Re: Proposal to ban the usage of refcounted objects inside C++ lambdas in Gecko

On Fri, Apr 10, 2015 at 10:37 AM, Ehsan Akhgari wrote: > On 2015-04-10 12:33 PM, Andrew McCreight wrote: > >> >> >> On Fri, Apr 10, 2015 at 8:46 AM, Ehsan Akhgari > > wrote: >> >> I would like to propose that we should ban the usage of refcounted >> objects