Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-29 Thread smaug
On 03/28/2015 02:32 AM, Nicolas B. Pierron wrote: On 03/27/2015 11:51 PM, Bobby Holley wrote: On Fri, Mar 27, 2015 at 2:04 PM, Mats Palmgren wrote: So let's change the project-wide coding rules instead to allow 99 columns as the hard limit, but keep 80 columns as the recommended (soft) limit.

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-29 Thread Karl Tomlinson
Bobby Holley writes: > On Fri, Mar 27, 2015 at 2:04 PM, Mats Palmgren wrote: > > So let's change the project-wide coding rules instead to allow 99 >> columns as the hard limit, but keep 80 columns as the recommended >> (soft) limit. >> > > I think we should avoid opening up a can of worms on the

Re: From nsIntSize to gfx::IntSize

2015-03-29 Thread Botond Ballo
On Sun, Mar 29, 2015 at 5:01 PM, Mats Palmgren wrote: > On 03/27/2015 09:28 PM, Robert O'Callahan wrote: >> >> As a followup it's probably worth replacing all of nsIntSize with >> gfx::IntSize. > > I think we should stop using these unit-less types in layout and > convert the few remaining uses to

Re: From nsIntSize to gfx::IntSize

2015-03-29 Thread Mats Palmgren
On 03/27/2015 09:28 PM, Robert O'Callahan wrote: As a followup it's probably worth replacing all of nsIntSize with gfx::IntSize. I think we should stop using these unit-less types in layout and convert the few remaining uses to the unit-bearing types in layout/base/Units.h instead. I'm taking

Re: From nsIntSize to gfx::IntSize

2015-03-29 Thread Robert O'Callahan
Two typedefs for the same thing is just cognitive overhead. Some judicious typedefs in classes like nsIFrame would be helpful so we don't have "gfx::" prefixes cluttering up everywhere. Rob -- oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo owoiotoho oao oboroootohoeoro o

TBPL now redirects to Treeherder

2015-03-29 Thread Ed Morley
The TBPL -> Treeherder redirects have now been deployed to production, to allow a day or so of bake time before we switch off TBPL for good. They handle tree/pusher/revision URL params, so the vast majority of legacy TBPL links will redirect to an equivalent Treeherder page [1]. Many thanks to ev

Re: From nsIntSize to gfx::IntSize

2015-03-29 Thread Nicolas Silva
On Fri, Mar 27, 2015 at 10:50 PM, Jet Villegas wrote: > Probably safe for the integer types, but can we add strong assertions when > converting from Thebes and Moz2D floats? Bugs like this one are tough to > debug: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1091709 > > Thanks! > > I haven'

Re: From nsIntSize to gfx::IntSize

2015-03-29 Thread Nicolas Silva
The first part just landed on inbound (Bug 1132854). On Fri, Mar 27, 2015 at 10:28 PM, Robert O'Callahan wrote: > Sounds good. But, is gfx::IntSize going to get a "ToAppUnits" method like > nsIntSize has? > > The method: nsIntSize::ToAppUnits(nscoord aAppUnitsPerPixel) const was replaced by a f