Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Martin Thomson
On Fri, Mar 27, 2015 at 7:59 PM, Botond Ballo wrote: > It would be really nice if there was a way to annotate whitespace-only > changesets as being such, and then configure tools such as "hg blame" > to "look past" them. You mean `hg blame -w` ? ___ de

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Botond Ballo
> and security issues as contributors (including employees) > do not look for the original authors. It would be really nice if there was a way to annotate whitespace-only changesets as being such, and then configure tools such as "hg blame" to "look past" them. Cheers, Botond

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Bobby Holley
On Fri, Mar 27, 2015 at 5:32 PM, Nicolas B. Pierron < nicolas.b.pier...@mozilla.com> wrote: > On 03/27/2015 11:51 PM, Bobby Holley wrote: > >> On Fri, Mar 27, 2015 at 2:04 PM, Mats Palmgren wrote: >> >> So let's change the project-wide coding rules instead to allow 99 >> >>> columns as the hard l

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Nicolas B. Pierron
On 03/27/2015 11:51 PM, Bobby Holley wrote: On Fri, Mar 27, 2015 at 2:04 PM, Mats Palmgren wrote: So let's change the project-wide coding rules instead to allow 99 columns as the hard limit, but keep 80 columns as the recommended (soft) limit. I think we should avoid opening up a can of wor

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Bobby Holley
On Fri, Mar 27, 2015 at 2:04 PM, Mats Palmgren wrote: So let's change the project-wide coding rules instead to allow 99 > columns as the hard limit, but keep 80 columns as the recommended > (soft) limit. > I think we should avoid opening up a can of worms on the merits of different styles, and i

Re: From nsIntSize to gfx::IntSize

2015-03-27 Thread Jet Villegas
Probably safe for the integer types, but can we add strong assertions when converting from Thebes and Moz2D floats? Bugs like this one are tough to debug: https://bugzilla.mozilla.org/show_bug.cgi?id=1091709 Thanks! --Jet On Fri, Mar 27, 2015 at 9:44 AM, Nicolas Silva wrote: > As many of you

Re: From nsIntSize to gfx::IntSize

2015-03-27 Thread Robert O'Callahan
Sounds good. But, is gfx::IntSize going to get a "ToAppUnits" method like nsIntSize has? As a followup it's probably worth replacing all of nsIntSize with gfx::IntSize. Rob -- oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo owoiotoho oao oboroootohoeoro oooro osoiosotoeor

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Mats Palmgren
On 03/27/2015 04:42 PM, Jan De Mooij wrote: On the other hand, going from 99 columns to 80 will also be annoying in a bunch of places. I don't think that's necessary. Let's relax our 80-column rule in Gecko instead. We can keep it as a recommendation, but allow longer lines when it improves r

Re: Updating the policy for Talos performance regression in 2015

2015-03-27 Thread Joel Maher
As one of the primary people sheriffing alerts, I have found that we get decisions made much faster as a result of this policy. I would be interested to hear if others have differing opinions as I could be seeing this with tunnel vision. -Joel On Fri, Mar 27, 2015 at 4:34 PM, Lawrence Mandel w

Re: Updating the policy for Talos performance regression in 2015

2015-03-27 Thread Lawrence Mandel
Old thread but now that we're 3 months into 2015, has this new policy been effective at getting perf regressions fixed or at least deliberately accepted? Lawrence On Fri, Dec 19, 2014 at 1:33 PM, wrote: > Great questions folks. > > :bsmedberg has answered the questions quite well, let me elabor

From nsIntSize to gfx::IntSize

2015-03-27 Thread Nicolas Silva
As many of you know, the introduction of Moz2D a while ago added new size, point and rect classes which are equivalent* to the ones that already existed in tree (nsIntSize, etc.). Juggling back and forth between the Moz2D classes and their thebes equivalent is pretty annoying and until now we have

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Jan De Mooij
On Fri, Mar 27, 2015 at 5:12 PM, Bobby Holley wrote: > On Thu, Mar 26, 2015 at 10:37 PM, Birunthan Mohanathas < > birunt...@mohanathas.com> wrote: > >> I've done all of that and more on a few directories (e.g. xpcom/ in >> bug 1046841). If we reach consensus regarding js/ style, I could take >> c

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Bobby Holley
On Thu, Mar 26, 2015 at 10:37 PM, Birunthan Mohanathas < birunt...@mohanathas.com> wrote: > On 27 March 2015 at 01:19, Bobby Holley wrote: > > Can we switch from 4-space to 2-space indentation at some point too? > > Together, those would remove the most glaring formatting differences. The > > oth

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-27 Thread Nicolas B. Pierron
On 03/27/2015 12:19 AM, Bobby Holley wrote: Can we switch from 4-space to 2-space indentation at some point too? Yeah good idea, and we should probably scratch everything we have done so far and rewrite everything in whitespace. -- Nicolas B. Pierron _