Re: Removing ancient and unused code from tools/

2014-10-12 Thread ISHIKAWA, Chiaki
On 2014/10/13 13:36, Nicholas Nethercote wrote: - tools/rb/ -- most, if not all, scripts actively used Thank you for the clean up work. I am using fix_linux_stack tool under tools/rb/ for cleaning up non symbolic stack trace in the log of DEBUG BUILD of TB when I am testing it

Removing ancient and unused code from tools/

2014-10-12 Thread Nicholas Nethercote
Hi, About half of the contents of the tools/ directory is useful stuff, and the other half is ancient and unused stuff that hasn't been touched since the early 2000s. I've gone through and written patches to remove the latter half. can. The meta-bug tracking this work is https://bugzilla.mozilla.o

Re: Incorrect line number reported by JS engine for warnings?

2014-10-12 Thread ISHIKAWA, Chiaki
Sorry for top posting. Mea Culpa: I was looking at the wrong file as Boris correctly pointed out. These two bugs were seen in the timeout test case mentioned first in https://bugzilla.mozilla.org/show_bug.cgi?id=1081763 Bug 1081763 - C-C TB: gContextMenu is undefined during test that eventually

Re: Incorrect line number reported by JS engine for warnings?

2014-10-12 Thread Boris Zbarsky
On 10/12/14, 9:54 PM, ISHIKAWA, Chiaki wrote: > In this bugzilla, line 693 is actually out of range for the file reported. > The file is much shorter. Is it? The error is in nsContextMenu.js but your comments in the bug are about mailContextMenus.js, which is not at all the same thing. > Worse,

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-12 Thread Robert O'Callahan
On Sun, Oct 12, 2014 at 12:06 PM, Giuseppe Bilotta < giuseppe.bilo...@gmail.com> wrote: > Indeed. My patch only aims at providing a generic fallback. In > contexts where it is known how the desktop environment handles the DPI > settings, that convention should be followed. But in most cases, this

Incorrect line number reported by JS engine for warnings?

2014-10-12 Thread ISHIKAWA, Chiaki
Lately, the stricter checks from JS engines produced many warnings during the test suite run (|make mozmill|) of locally built DEBUG BUILD of C-C thunderbird. These in themselves are very good to make code better, more robust, etc. However, today I noticed a few problems of line numbers thus repo

Re: [RFC] Linux HiDPI support: choose default scale factor based on DPI

2014-10-12 Thread Robert O'Callahan
On Sun, Oct 12, 2014 at 1:41 AM, Giuseppe Bilotta < giuseppe.bilo...@gmail.com> wrote: > On Fri, Oct 10, 2014 at 4:46 PM, Nicolas Silva > wrote: > > In the mean time we should really detect hidpi screens and default to an > appropriate scale. > > The current scale is a terrible experience on a hi