MakeUnique(..., nullptr, ...) will break *only* the b2g-ics build

2014-08-06 Thread Jeff Walden
An issue with MakeUnique that I forgot to mention: you can't pass literal nullptr to MakeUnique. This problem happens because gcc < 4.6 doesn't support true nullptr, and that interacts poorly with perfect forwarding. See the long comment in mfbt/Move.h for details. *Only* b2g-ics will break i

Re: Telemetry alerts for histograms

2014-08-06 Thread Jim (Ningjie) Chen
Looks great! Is the system specific to histograms or can it be adapted to other telemetry measurements? Looking at the dashboard, we have a growing list of telemetry measurements outside of histograms (hangs, experiments, I/O, power usage, etc.). It'd be great if they can benefit from automatic

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Chris Peterson
Thanks, I now see distinction you are making. <:) On 8/6/14 10:32 AM, Benjamin Smedberg wrote: On 8/6/2014 1:20 PM, Chris Peterson wrote: I don't understand this sentence, but I strongly oppose automatically clearing Static*Ptr in the static destructor in any build. In the past we have had

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Benjamin Smedberg
On 8/6/2014 1:20 PM, Chris Peterson wrote: I don't understand this sentence, but I strongly oppose automatically clearing Static*Ptr in the static destructor in any build. In the past we have had static comptr cause final release of objects after XPCOM shutdown, which causes crashes due to the

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Chris Peterson
On 8/6/14 7:11 AM, Benjamin Smedberg wrote: Not only that, but it also makes our code correct. There is nothing to guarantee that one of those destrcutors we're skipping right now would not have observable side effects passed shutdown. So until somone comes up with an idea on how to enforce that

Re: Telemetry alerts for histograms

2014-08-06 Thread Gian-Carlo Pascutto
On 08/06/2014 06:42 PM, rviti...@mozilla.com wrote: > Agreed, I am going to create a new catch-all mailing list. Our > original intent was actually for authors to use an e-mail alias like > in Bug 1047568 or let them use their own mailing lists. Seems fine. > But we can certainly send all aler

Re: Telemetry alerts for histograms

2014-08-06 Thread rvitillo
On Wednesday, August 6, 2014 8:16:09 AM UTC+1, Gian-Carlo Pascutto wrote: > On 5/08/2014 22:09, Andrew McCreight wrote: > > How many alerts is this thing going to generate? Could you have a > > mailing list that just gets all of the telemetry alerts email and > > then people could subscribe to it

Re: Are StaticAuto/RefPtr good?

2014-08-06 Thread Benjamin Smedberg
That accounting is useful on debug builds. Arguably, debug builds don't have to care about avoiding static initializers. So we could add a destructor to Static*Ptrs on debug builds that: - sends a error that ClearOnShutdown was not called on them or - clears them to clear the leak or - both (rep

Web APIs documentation meeting on Friday at 10 AM PDT

2014-08-06 Thread Eric Shepherd
The Web APIs documentation meeting is Friday at 10 AM Pacific Time (see http://bit.ly/APIDocsMeeting for your time zone). Everyone's welcome to attend; if you're interested in ensuring that all Web APIs are properly documented, we'd love your input. We have an agenda, as well as details on how

Re: Tree Closure Stats - July 2014

2014-08-06 Thread David Burns
One of the items that has limited the closures is the new requirement from Sheriffs that if there is a checkin-needed that there is a try push for that patch. There has also been changes from Releng about being able to run arbitary jobs against a build which wasnt there before which has helped

Re: Intent to implement: webserial api

2014-08-06 Thread Alexandros Chronopoulos
A discussion has been raised in web-api list about the security model of webserial. Feel free to provide your input. -Alex On Mon, Aug 4, 2014 at 1:01 AM, Florian Bender < florian.ben...@quantumedia.de> wrote: > Am Dienstag, 15. Juli 2014 21:01:19 UTC+2 schrieb somb...@gmail.com: > > I think an

Re: Telemetry alerts for histograms

2014-08-06 Thread Gian-Carlo Pascutto
On 5/08/2014 22:09, Andrew McCreight wrote: > This looks really great! > > How many alerts is this thing going to generate? Could you have a > mailing list that just gets all of the telemetry alerts email and > then people could subscribe to it if they wanted? (Technically, I > suppose I could m