Re: OMTC on Windows

2014-05-18 Thread avihal
On Monday, May 19, 2014 4:36:49 AM UTC+3, Boris Zbarsky wrote: > On 5/18/14, 2:23 PM, Gavin Sharp wrote: > > > OMTC is important, and I'm excited to see it land > > > on Windows, but the Firefox and Performance teams have just come off a > > > months-long effort to make significant wins in TART,

Re: Gecko style: Formatting function return type and specifiers

2014-05-18 Thread Karl Tomlinson
Birunthan Mohanathas writes: > For top-level function definitions, the recommended style is: > > template > static inline T > Foo() > { > // ... > } The main reasons for having the function name at the start of a new line, I assume, was to help some tools (including diff

Re: Gecko style: Formatting function return type and specifiers

2014-05-18 Thread Dave Hylands
I've seen both styles used, although I think that int Foo(); is the most common style when declaring a function prototype in a class header. Generally speaking its more important to be consistent with the rest of the file. Dave Hylands - Original Message - > From: "Birunthan Moh

Re: Gecko style: Braces with enums and uninons

2014-05-18 Thread Dave Hylands
My interpretation of this is that the only time braces go on the end of the line is when you're starting a "control structure" https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Control_Structures structs, enums, classes, and functions are not control structures, so

Re: Intent to implement and ship: navigator.hardwareConcurrency

2014-05-18 Thread Rik Cabanier
On Sun, May 18, 2014 at 4:51 PM, Xidorn Quan wrote: > IMO, though we may have a better model in the future, it is at least not > harmful to have such attribute with some limitation. The WebKit guys think > it is not a fingerprinting when limiting the max value to 8. I think it > might be meaningf

Intent to implement: ResourceStats API

2014-05-18 Thread Borting Chen
Summary: ResourceStats API supports resource statistics and cost control for network usage and power consumption. Resource statistics provides resource usage information about the whole system, a system service, or an application. Cost control notifies user when resource usage exceeds a define

Re: OMTC on Windows

2014-05-18 Thread Boris Zbarsky
On 5/18/14, 2:23 PM, Gavin Sharp wrote: OMTC is important, and I'm excited to see it land on Windows, but the Firefox and Performance teams have just come off a months-long effort to make significant wins in TART, and the thought of taking a 20% regression (huge compared to some of the improvemen

Re: Intent to implement and ship: navigator.hardwareConcurrency

2014-05-18 Thread Xidorn Quan
IMO, though we may have a better model in the future, it is at least not harmful to have such attribute with some limitation. The WebKit guys think it is not a fingerprinting when limiting the max value to 8. I think it might be meaningful to also limit the number to power of 2 (very few people has

Re: Intent to implement and ship: navigator.hardwareConcurrency

2014-05-18 Thread Rik Cabanier
FYI this attribute landed in WebKit today: http://trac.webkit.org/changeset/169017 On Thu, May 15, 2014 at 1:26 AM, Rik Cabanier wrote: > > > > On Wed, May 14, 2014 at 11:39 AM, Ehsan Akhgari > wrote: > >> On 2014-05-13, 9:01 PM, Rik Cabanier wrote: >> >>> ... >>> >>> The problem is that t

Re: OMTC on Windows

2014-05-18 Thread Bas Schouten
Hi Armen, You -could- be seeing all kinds of bugs, but the most likely things I'd be expecting is things while window shapes and such are updating (i.e. resizing, pop-up windows, awesomebar, etc.) particularly since those type of short-lived compositors are not typical on mobile devices where w

Re: OMTC on Windows

2014-05-18 Thread avihal
Re TART regressions and Gavin's concerns - as always, we should not trust the numbers blindly. The first thing we need is probably taking few windows machines with different performance characteristics and compare tab animation perf on those machines, especially on the cases where TART shows re

Re: OMTC on Windows

2014-05-18 Thread Bas Schouten
Hi Gavin, There have been several e-mails on different lists, and some communication on some bugs. Sadly the story is at this point not anywhere in a condensed form, but I will try to highlight a couple of core points, some of these will be updated further as the investigation continues. The of

Re: OMTC on Windows

2014-05-18 Thread Chris Peterson
That's awesome news, Bas! OMTC on Windows has been one of the major dependencies for e10s. AFAIU, Nightly users on Windows should now be able to test per-window e10s without tweaking any prefs or restarting the browser. To open an e10s window, open "File (or Hamburger)" menu then "New e10s Win

Re: OMTC on Windows

2014-05-18 Thread Gavin Sharp
> but tart will regress by ~20%, and several other suites will regress as well. > We've investigated this extensively and we believe the majority of these > regressions are due to the nature of OMTC and the fact that we have to do > more work. Where can I read more about the TART investigations? I

Re: OMTC on Windows

2014-05-18 Thread Armen Zambrano G.
What kind of bugs could we expect seeing? Any place you would like us to put focus on testing? Thanks for all the hard work to get this in. cheers, Armen On 2014-05-18, 3:16 AM, Bas Schouten wrote: > Hey all, > > After quite a lot of waiting we've switched on OMTC on Windows by default > today

Gecko style: Braces with enums and uninons

2014-05-18 Thread Birunthan Mohanathas
While working on bug 995730, I bumped into a few things that the Gecko style guide leaves unspecified. I have described one such case below. I'll create separate threads for the other things in order to maximize the number of bikeshedding threads (and for readability). For classes and structs, bra

Gecko style: Line-continuation backslash in macros

2014-05-18 Thread Birunthan Mohanathas
(Note: Use a monospace font to view this message or use .) The placement of the line-continuation backslash in macros is wildly inconsistent. Some put the backslash directly after the line: #define NS_IMPL_CYCLE_COLLECTION_CAN_SKIP_IN_CC_BEG

Gecko style: Formatting function return type and specifiers

2014-05-18 Thread Birunthan Mohanathas
For top-level function definitions, the recommended style is: template static inline T Foo() { // ... } However, for function declarations and inline member functions, there does not seem to be a definitive style. Some use: int Foo(); class Bar { virt

OMTC on Windows

2014-05-18 Thread Bas Schouten
Hey all, After quite a lot of waiting we've switched on OMTC on Windows by default today (bug 899785). This is a great move towards moving all our platforms onto OMTC (only linux is left now), and will allow us to remove a lot of code that we've currently been duplicating. Furthermore it puts u