On 4/11/14 10:41 PM, Boris Zbarsky wrote:
4) A reference to a WebIDL-binding object which inherits from both
nsWrapperCache and nsISupports.
5) A reference to any C++ type which singly-inherits from nsISupports
(e.g. any nsIFoo).
6) An nsRefPtr or nsCOMPtr around an object that satisfies
TL;DR: If you need to produce a JS::Value from some C++ type, use
mozilla::dom::ToJSValue. Anything else will probably need to be
search-and-replaced out of the codebase later.
Background: There are some situations in which it's not possible to just
use WebIDL bindings to handle conversions
Whoa, didn't expect to see a blog post I wrote in grad school to get
called out here. :) Interesting to see it show up on the radar.
Re-reading it, I think the most interesting thing about the Cohen study
that I absorbed was the value of reviewing my own code before requesting
review from other pe
The Firefox desktop team is heavily relying on bugs being marked in some way to know if
we need to verify them or perform some other action on them. For that, our QA drivers for
example triage the bugs fixed in every development cycle and mark them
"verifyme" or [qa-]. I've also seen [qa+] floa
Code review tool company SmartBear published an interesting study [1] of
the effectiveness of code reviews at Cisco. (They used SmartBear's
tools, of course.) Mozillian Mike Conley reviewed SmartBear's study on
his blog [2].
The results are interesting and actionable. Some highlights:
* Revie
I came across the following articles on source control and code review:
*
https://secure.phabricator.com/book/phabflavor/article/recommendations_on_revision_control/
*
https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/
*
https://secure.phabricator.com/book/phabflav
The Web API documentation meeting is today at 9 AM Pacific Time.
Everyone's welcome to attend; if you're interested in ensuring that
these APIs are properly documented, we'd love your input.
We have an agenda, as well as details on how to join, here:
https://etherpad.mozilla.org/WebAPI-docs-20
7 matches
Mail list logo
