Re: Please do not add new web-exposed XPCOM objects

2014-03-15 Thread Boris Zbarsky
On 3/15/14 4:31 PM, smaug wrote: I think we should add some checks to test_interfaces to enforce this. (Assuming we can detect xpcom stuff via different kind of prototypes vs. webidl implemented stuff) We actually can: the toString() in the prototype object returns very different things in the

Changes to already_AddRefed and getter_AddRefs

2014-03-15 Thread Kyle Huey
I have made changes to already_AddRefed (Bug 967364) and getter_AddRefs (Bug 345123) to eliminate some potential mistakes that can be made with them. For already_AddRefed: - already_AddRefed::get() has been renamed to already_AddRefed::take(), to make the transfer of ownership of the pointer in q

Re: Please do not add new web-exposed XPCOM objects

2014-03-15 Thread smaug
On 03/14/2014 11:20 PM, Boris Zbarsky wrote: We're at a point where we are actively trying to eliminate xpconnect usage on the web. I'm happy to enumerate the reasons we're doing that if people care, but the practical upshot is: 1) Do not add new objects with classinfo to nsDOMClassInfo.cpp