Re: IID Abuse

2014-03-06 Thread L. David Baron
On Friday 2014-03-07 01:32 +, Neil wrote: > Because of the way GetIID/NS_GET_IID works, it's not very easy to > get the compiler to tell you when you're doing it wrong. So far I've > come up with a way to get the linker to do it. I'm trying to get the > compiler to do it, but the results aren't

Re: Using preferences off the main thread now asserts

2014-03-06 Thread L. David Baron
On Thursday 2014-03-06 19:52 -0800, Nicholas Nethercote wrote: > On Thu, Mar 6, 2014 at 8:20 AM, Kyle Huey wrote: > > It's taken over 3 years, but Bug 619487 is now fixed, and the > > preferences service will assert (fatally) if you try to use it off the > > main thread. > > Out of curiosity, wha

Re: Using preferences off the main thread now asserts

2014-03-06 Thread Nicholas Nethercote
On Thu, Mar 6, 2014 at 8:20 AM, Kyle Huey wrote: > It's taken over 3 years, but Bug 619487 is now fixed, and the > preferences service will assert (fatally) if you try to use it off the > main thread. Out of curiosity, what's the benefit of this? Is it just a correctness issue? The bug didn't hav

IID Abuse

2014-03-06 Thread Neil
Because of the way GetIID/NS_GET_IID works, it's not very easy to get the compiler to tell you when you're doing it wrong. So far I've come up with a way to get the linker to do it. I'm trying to get the compiler to do it, but the results aren't perfect. However along the way I have noticed som

Re: Using preferences off the main thread now asserts

2014-03-06 Thread Benoit Girard
Thanks for doing this. However I feel like our options for code that need preferences off the main thread are a bit poor. The first option is to send an IPC message to the main thread but that has very poor performance, requires a lot of boilerplate code and either an sync message or async+restruc

Re: Using preferences off the main thread now asserts

2014-03-06 Thread Bobby Holley
Huzzah! Well done Kyle. On Mar 6, 2014 8:20 AM, "Kyle Huey" wrote: > It's taken over 3 years, but Bug 619487 is now fixed, and the > preferences service will assert (fatally) if you try to use it off the > main thread. This is currently disabled on b2g while I track down the > last misuses of th

Using preferences off the main thread now asserts

2014-03-06 Thread Kyle Huey
It's taken over 3 years, but Bug 619487 is now fixed, and the preferences service will assert (fatally) if you try to use it off the main thread. This is currently disabled on b2g while I track down the last misuses of the pref service in b2g-specific code. After the next train leaves I plan to u