Re: DXR UI refresh is live!

2014-02-08 Thread Neil
Erik Rose wrote: https://blog.mozilla.org/webdev/2014/02/07/dxr-gets-a-huge-ui-refresh/ Why are you double spacing the output and then "fixing" it by hard-coding .7 line spacing for the source and 1.4 for the line numbers? Also although most of your CSS uses classes, some of it uses :firs

Re: DXR UI refresh is live!

2014-02-08 Thread Erik Rose
Fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=969887#c1. It will take effect with the next re-index, in a few hours. Good eye! Somehow, nobody caught this on staging or locally, though it seems obvious in retrospect. While I was at it, I stopped the code from jumping to the side when you

Re: DXR UI refresh is live!

2014-02-08 Thread Tom Schuster
The design looks really fresh, I really like the new colors. I am however wondering about additional spaces that were introduced, they seem to even break indentation: http://dxr.mozilla.org/mozilla-central/source/js/src/jsapi.cpp#1426. -Tom On Sat, Feb 8, 2014 at 1:29 AM, Erik Rose wrote: > >