Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Neil
Ms2ger wrote: On 12/20/2013 10:55 AM, Neil wrote: I thought that it was pretty clear which smart pointer to use: That makes it quite clear it isn't clear: nsCOMPtr - interfaces nsRefPtr - concrete types RefPtr - code imported from WebKit HTH MXR claims we have three types named RefPtr. O

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Chris Peterson
On 12/19/13, 6:50 PM, Bobby Holley wrote: And that should include accepting patches to fix the style across their >module. ;-) > FWIW I'm totally fine with mass-conversions if people want to do them. Any mass conversions of code style should coincide with the next ESR release. Imagine the pr

Re: nsIDownloadManager replaced by Downloads.jsm

2013-12-20 Thread jruby2bluestacks
On Saturday, August 3, 2013 7:21:57 AM UTC-5, Paolo Amadini wrote: > Hello, I am nobody. But, I want file timestamps to be preserved when I download files. I guess I will use wget until this gets fixed. Now I have no reason to use Firefox. I was using this until todays upgrade to FF 26: "Prese

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Ms2ger
On 12/20/2013 10:55 AM, Neil wrote: Brian Smith wrote: In PSM, we created some scoped pointer wrapper types around NSS data structures (ScopedNSSTypes.h), which are based on the MFBT scoped pointers. And, consequently, PSM has standardized on MFBT smart pointers throughout the module (there sho

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Nicolas B. Pierron
On 12/19/2013 09:57 AM, Till Schneidereit wrote: I think we should do more than encourage: we should back out for all style guide violations. Period. We could even enforce that during upload to a review tool, perhaps. Is this a guide or a rule? From my point of view, this is a guide, which is

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Neil
Ehsan Akhgari wrote: To be very specific, here's a number of examples of things which our code base doesn't agree on: 1. Line endings Which is probably the easiest and least controversial thing to check for. I blame whoever it was who decided to include a vim that defaults to DOS line endi

Re: On the usefulness of style guides (Was: style guide proposal)

2013-12-20 Thread Neil
Brian Smith wrote: In PSM, we created some scoped pointer wrapper types around NSS data structures (ScopedNSSTypes.h), which are based on the MFBT scoped pointers. And, consequently, PSM has standardized on MFBT smart pointers throughout the module (there should be nsRefPtr in PSM, only RefPt