Re: #define TEST_MODE* for TBPL builds?

2013-11-13 Thread ISHIKAWA,chiaki
(2013/11/14 9:18), Ted Mielczarek wrote: On 11/13/13 3:34 PM, Mike Habicher wrote: Hello everyone, I'm working on automated tests for Gecko's camera code on B2G, and I want to replace different pieces of the implementation with fake objects that return one or more injected error codes so that I

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Bobby Holley
On Wed, Nov 13, 2013 at 5:33 PM, Robert O'Callahan wrote: > Does this mean that currently, if a page creates an IFRAME, loads url A > into it, then loads url B into it, sessionstore.js will contain state for > both A and B? > > That does seem excessive. > Yeah. If we _do_ decide to emulate Gecko'

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Robert O'Callahan
On Wed, Nov 13, 2013 at 5:09 AM, David Rajchenbach-Teller < dtel...@mozilla.com> wrote: > Or we could not save dynamic iframes in non-current positions in the > history. > Does this mean that currently, if a page creates an IFRAME, loads url A into it, then loads url B into it, sessionstore.js wi

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Robert Kaiser
David Rajchenbach-Teller schrieb: Or we could not save dynamic iframes that are not visible. It sounds to me personally like this would be the most sensible option. Do we know what, if anything, would break with this on the real web? Do we have any e.g. telemetry data for how often those are

Re: #define TEST_MODE* for TBPL builds?

2013-11-13 Thread Ted Mielczarek
On 11/13/13 3:34 PM, Mike Habicher wrote: Hello everyone, I'm working on automated tests for Gecko's camera code on B2G, and I want to replace different pieces of the implementation with fake objects that return one or more injected error codes so that I can exercise all of the error-handling

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread David Rajchenbach-Teller
We could do that. This might make the behavior of Firefox a little harder to predict for web devs, though. Cheers, David On 11/13/13 7:38 PM, Mike de Boer wrote: > Perhaps we could take a nuanced version of this option... > >> Or we could not save dynamic iframes that are not visible. > > …cha

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread David Rajchenbach-Teller
On 11/13/13 10:27 PM, Robert O'Callahan wrote: > When you say "iframes" you mean content documents that aren't toplevel > content documents, right? Indeed. > Can you explain why sessionstore.js needs to observe > non-toplevel-content documents at all? I assume there's an obvious > answer, I just

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Robert O'Callahan
When you say "iframes" you mean content documents that aren't toplevel content documents, right? Can you explain why sessionstore.js needs to observe non-toplevel-content documents at all? I assume there's an obvious answer, I just don't know what it is :-). Rob -- Jtehsauts tshaei dS,o n" Wohf

Re: #ifdefing out mailnews-only code but keeping it in m-c

2013-11-13 Thread Andrew Sutherland
On 11/12/2013 03:39 AM, Henri Sivonen wrote: On Mon, Nov 11, 2013 at 10:08 PM, Andrew Sutherland wrote: On 11/11/2013 01:33 PM, Joshua Cranmer 🐧 wrote: Actually, I believe you need to keep the x-imap4-modified-utf7 converters in B2G, if you don't want to break Gaia Email's tests. They use the

Re: #define TEST_MODE* for TBPL builds?

2013-11-13 Thread Gregory Szorc
I think providing a non-public API to modify the run-time behavior of code, using gtest's FRIEND_TEST macro to give tests the ability to modify private class members, or using Google's "googlemock" C++ mocking framework are all better than littering #ifdefs like this throughout the code. Furt

#define TEST_MODE* for TBPL builds?

2013-11-13 Thread Mike Habicher
Hello everyone, I'm working on automated tests for Gecko's camera code on B2G, and I want to replace different pieces of the implementation with fake objects that return one or more injected error codes so that I can exercise all of the error-handling paths. None of this code needs to be inc

Re: what is the difference between Tb/Fx minor and patch version bumps

2013-11-13 Thread Benjamin Smedberg
On 11/13/2013 3:11 PM, al...@yahoo.com wrote: e.g. the first Fx24 esr update was 24.1.0, the next one is 24.1.1 what circumstances call for one vs. the other We are spinning a Firefox 25.0.1 build to fix some important regressions. So: 25 == 24.1.0ESR 25.0.1 == 24.1.1ESR 26 == 24.2ESR (future

what is the difference between Tb/Fx minor and patch version bumps

2013-11-13 Thread al_9x
e.g. the first Fx24 esr update was 24.1.0, the next one is 24.1.1 what circumstances call for one vs. the other ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Mike de Boer
Perhaps we could take a nuanced version of this option... > Or we could not save dynamic iframes that are not visible. …changing it to ‘Put a reasonable cap on the amount of history we store for invisible, dynamic iframes, using a fifo queue’? Mike. On Nov 13, 2013, at 2:09 PM, David Rajchenba

Re: [RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread Bobby Holley
I don't know much about sessionstore.js, but I imagine that the issues it faces are similar to those of navigation and session history, which I've been involved with recently from the servo and spec angles. Restoring dynamically generated iframes is undecidable. This doesn't stop Gecko from trying

Shared Desktop and Metro profile work on mozilla-central

2013-11-13 Thread Brian R. Bondy
Over the past few weeks, we've been working on Metro and Desktop shared profiles. You can find some background information about this work on my blog [here][1]. Within the next week, if QA gives us the OK, well, we'll be uplifting the Metro and Desktop shared profile work from the oak branch to

[RFC] Should we persist dynamically generated iframes?

2013-11-13 Thread David Rajchenbach-Teller
*** The problem We are currently faced with a problem on facebook.com (see bug 934935) that brings Firefox to its knees because our session restore accumulates huge amounts of dead data. This problem is most likely a Facebook bug, and we are in touch with the Facebook team to see if they can addre

Re: Plug-in feature not available in the web platform. Alternatives?

2013-11-13 Thread helpcrypto helpcrypto
Hi. My two cents. On Sat, Nov 9, 2013 at 5:13 PM, Benjamin Smedberg wrote: > On 11/8/2013 4:33 AM, fma spew wrote: > >> We have a npapi-npruntime plug-in that access the Windows certificate >> store >> via CAPI to provide the end-user with its personal certificates to perform >> different operat

Re: Plug-in feature not available in the web platform. Alternatives?

2013-11-13 Thread Henri Sivonen
On Wed, Nov 13, 2013 at 12:10 AM, Matt Brubeck wrote: > One alternative is a Firefox extension. Compared to cross-browser NPAPI plug-ins, it seems worse to have browser-specific extensions that expose functionality to Web content. > We've also mentioned the possibility of bundling a traditional