Re: Tegra build backlog is too big!

2013-09-12 Thread Justin Wood
> hi kats (cross-posting to dev-b2g); > > tl:dr; we think all is ok again, details below. To avoid this happening > again this week, we're changing tryserver to reduce the number of > Android-tests-run-on-tegra-by-default. If you specifically want tegra > testing on tryserver, you will need to sta

Re: Including just to get std::min and std::max

2013-09-12 Thread Trevor Saunders
On Thu, Sep 12, 2013 at 11:59:30PM +0200, Julian Seward wrote: > On 09/12/2013 11:08 PM, Chris Peterson wrote: > > On 9/12/13 6:35 AM, Mike Hommey wrote: > >> Note we have *many* inline functions that the compiler decide to never > >> inline. We should maybe try to detect those on all platforms and

Re: Including just to get std::min and std::max

2013-09-12 Thread Nicholas Cameron
I suppose that that metric will be different between compilers (msvc vs gcc vs clang (which we don't officially build with, but I bet is the easiest to get the info out of)), and possibly between platforms, versions, etc. I wouldn't be surprised if the context in which the header is included mak

Re: Including just to get std::min and std::max

2013-09-12 Thread Julian Seward
On 09/12/2013 11:08 PM, Chris Peterson wrote: > On 9/12/13 6:35 AM, Mike Hommey wrote: >> Note we have *many* inline functions that the compiler decide to never >> inline. We should maybe try to detect those on all platforms and move >> those functions out of headers. > > gcc -Winline will report

Re: Including just to get std::min and std::max

2013-09-12 Thread Chris Peterson
On 9/12/13 6:35 AM, Mike Hommey wrote: Note we have *many* inline functions that the compiler decide to never inline. We should maybe try to detect those on all platforms and move those functions out of headers. gcc -Winline will report uninlined "inline" functions, but the warnings are VERY n

Re: Tegra build backlog is too big!

2013-09-12 Thread Kartikaya Gupta
Thanks John, this looks like it strikes a good balance between reducing tegra load and getting false-positives in try runs. Just for anybody following along though, it looks like bug 915465 (which deployed this change) is still in flux so things may have not completely settled yet. See also h

Re: Including just to get std::min and std::max

2013-09-12 Thread Mike Hommey
On Thu, Sep 12, 2013 at 07:19:54AM -0400, Benoit Jacob wrote: > 2013/9/12 Avi Hal > > > On Sunday, September 8, 2013 6:22:01 AM UTC+3, Benoit Jacob wrote: > > > Hi, > > > > > > > > > > > > It seems that we have some much-included header files including > > > > > > > > just to get std::min and st

Re: Including just to get std::min and std::max

2013-09-12 Thread Benoit Jacob
2013/9/12 Avi Hal > On Sunday, September 8, 2013 6:22:01 AM UTC+3, Benoit Jacob wrote: > > Hi, > > > > > > > > It seems that we have some much-included header files including > > > > > just to get std::min and std::max. > > > > Is it because min/max are used at the h file? Yes. can it be dele