Re: Coding style change proposal: #pragma once

2012-10-29 Thread Mike Hommey
On Mon, Oct 29, 2012 at 06:11:04PM -0700, Gregory Szorc wrote: > On 10/29/12 5:52 PM, Robert O'Callahan wrote: > >On Tue, Oct 30, 2012 at 1:13 PM, Nicholas Nethercote >>wrote: > > > >>"#pragma once does have one drawback (other than being non-standard) > >>and that is if you have the same file in

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Gregory Szorc
On 10/29/12 7:17 PM, Ehsan Akhgari wrote: On 2012-10-29 9:11 PM, Gregory Szorc wrote: On 10/29/12 5:52 PM, Robert O'Callahan wrote: On Tue, Oct 30, 2012 at 1:13 PM, Nicholas Nethercote wrote: "#pragma once does have one drawback (other than being non-standard) and that is if you have the sa

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Ehsan Akhgari
On 2012-10-29 9:11 PM, Gregory Szorc wrote: On 10/29/12 5:52 PM, Robert O'Callahan wrote: On Tue, Oct 30, 2012 at 1:13 PM, Nicholas Nethercote wrote: "#pragma once does have one drawback (other than being non-standard) and that is if you have the same file in different locations (we have thi

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Gregory Szorc
On 10/29/12 5:52 PM, Robert O'Callahan wrote: On Tue, Oct 30, 2012 at 1:13 PM, Nicholas Nethercote wrote: "#pragma once does have one drawback (other than being non-standard) and that is if you have the same file in different locations (we have this because our build system copies files aroun

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Robert O'Callahan
On Tue, Oct 30, 2012 at 1:13 PM, Nicholas Nethercote wrote: > "#pragma once does have one drawback (other than being non-standard) > and that is if you have the same file in different locations (we have > this because our build system copies files around) then the compiler > will think these are

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Nicholas Nethercote
On Mon, Oct 29, 2012 at 4:44 PM, Ehsan Akhgari wrote: > I'd like to switch our coding style to use #pragma once instead of #include > guards. http://stackoverflow.com/questions/787533/is-pragma-once-a-safe-include-guard/1946730#1946730 says: "#pragma once does have one drawback (other than being

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Ehsan Akhgari
On 2012-10-29 7:56 PM, Justin Lebar wrote: Not a concern, but the obvious question is: Do you have any idea how this affects compile times? It probably won't have any meaningful improvements, since all decent compilers already seem to special case #include guards. Ehsan

Re: Coding style change proposal: #pragma once

2012-10-29 Thread Justin Lebar
Not a concern, but the obvious question is: Do you have any idea how this affects compile times? On Mon, Oct 29, 2012 at 7:44 PM, Ehsan Akhgari wrote: > I'd like to switch our coding style to use #pragma once instead of #include > guards. #pragma once is supported on all compilers than can build

MemShrink meeting Tuesday 10/30/2012 @ 4:00pm PDT

2012-10-29 Thread Jet Villegas
This week's MemShrink meeting will be brought to you by a malloc/free implementation in javascript (via LLJS) https://github.com/mbebenita/LLJS/blob/master/src/memory.js The wiki page for this meeting is at: https://wiki.mozilla.org/Performance/MemShrink Agenda: * Prioritize unprioritized M

Coding style change proposal: #pragma once

2012-10-29 Thread Ehsan Akhgari
I'd like to switch our coding style to use #pragma once instead of #include guards. #pragma once is supported on all compilers than can build our source code, it is more concise, and it avoids possible name clashes in #include guards (or adopting silly conventions for avoiding them), and it can be

Re: HTML depth limit?

2012-10-29 Thread Rob Campbell
Mook also referenced this bug in IRC: [HTML5] HTML5 parser gives up easily with deeply nested tags https://bugzilla.mozilla.org/show_bug.cgi?id=512605 On 2012-10-29, at 15:57 , Mats Palmgren wrote: > On 10/29/2012 07:47 PM, Jan Honza Odvarko wrote: >> Is there any depth limit for HTML elements

Re: HTML depth limit?

2012-10-29 Thread Mats Palmgren
On 10/29/2012 07:47 PM, Jan Honza Odvarko wrote: Is there any depth limit for HTML elements in a document? Yes, around 200 or so. http://dxr.mozilla.org/search.cgi?tree=mozilla-central&string=MAX_REFLOW_DEPTH ___ dev-platform mailing list dev-platf

Re: HTML depth limit?

2012-10-29 Thread Rob Campbell
This sounds really familiar. Honza, did you run into this in the past? In any case, I was able to reproduce this with the attached test-case in your bug: http://cl.ly/KWCQ I asked Sebastian if he'd filed a bug on us yet, after my meeting I'll file it if he hasn't by then. On 2012-10-29, at 15

RE: HTML depth limit?

2012-10-29 Thread Benoit Girard
I actually run into the same problem with the cleopatra tree widget. Each tree level adds 2 or 3 levels to the DOM for that page so I think after 100 to 200 levels the expansion stops. Ehsan mentions that we have a limit on our frame tree as we use recursion but I don't know where this code lives.

HTML depth limit?

2012-10-29 Thread Jan Honza Odvarko
Is there any depth limit for HTML elements in a document? Related Firebug bug report: http://code.google.com/p/fbug/issues/detail?id=5780 Honza ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform