Re: try: -p all considered harmful?

2012-10-03 Thread Cameron McCormack
I would like a value like "all" but which means "all the platforms on which one of the tests I've listed runs". For example if I do "try: -p new-value -u crashtest,reftest" I want to get all platforms that run crashtests and/or reftests, so I can avoid say Armv7a ICS.

Re: try: -p all considered harmful?

2012-10-03 Thread Anthony Jones
On 04/10/12 01:10, Ben Hearsum wrote: I don't think anyone is saying that simply using try a lot is bad. But I think it's valid to question the usage if someone is always using "-p all". That's not to say it can't be valid/useful usage, just that it's more questionable than other usage. The w

Re: try: -p all considered harmful?

2012-10-03 Thread Gavin Sharp
On Wed, Oct 3, 2012 at 4:33 AM, Mounir Lamouri wrote: > On 09/29/2012 06:40 PM, Gavin Sharp wrote: >> On Sat, Sep 29, 2012 at 7:53 AM, Chris AtLee wrote: >>> http://people.mozilla.org/~catlee/highscores/highscores.html is a report of >>> where our time on Try is going. >> >> I think we should hav

Re: Extending jar.mn to support cross-module overrides

2012-10-03 Thread Mike Hommey
On Wed, Oct 03, 2012 at 03:52:38PM +0200, Axel Hecht wrote: > On 03.10.12 15:41, Mike Hommey wrote: > >On Wed, Oct 03, 2012 at 02:54:19PM +0200, Axel Hecht wrote: > >>On 03.10.12 14:33, Mike Hommey wrote: > >>>On Wed, Oct 03, 2012 at 02:01:02PM +0200, Axel Hecht wrote: > I've looked a bit deepe

Re: Extending jar.mn to support cross-module overrides

2012-10-03 Thread Axel Hecht
On 03.10.12 15:41, Mike Hommey wrote: On Wed, Oct 03, 2012 at 02:54:19PM +0200, Axel Hecht wrote: On 03.10.12 14:33, Mike Hommey wrote: On Wed, Oct 03, 2012 at 02:01:02PM +0200, Axel Hecht wrote: I've looked a bit deeper into the code, and there's unused functionality that I'd like to rip out

Re: Extending jar.mn to support cross-module overrides

2012-10-03 Thread Mike Hommey
On Wed, Oct 03, 2012 at 02:54:19PM +0200, Axel Hecht wrote: > On 03.10.12 14:33, Mike Hommey wrote: > >On Wed, Oct 03, 2012 at 02:01:02PM +0200, Axel Hecht wrote: > >>I've looked a bit deeper into the code, and there's unused > >>functionality that I'd like to rip out of JarMaker.py in favor of > >

Re: Extending jar.mn to support cross-module overrides

2012-10-03 Thread Axel Hecht
On 03.10.12 14:33, Mike Hommey wrote: On Wed, Oct 03, 2012 at 02:01:02PM +0200, Axel Hecht wrote: I've looked a bit deeper into the code, and there's unused functionality that I'd like to rip out of JarMaker.py in favor of this: Support for multiple jars in one go is one thing I'd love to axe.

Re: Extending jar.mn to support cross-module overrides

2012-10-03 Thread Mike Hommey
On Wed, Oct 03, 2012 at 02:01:02PM +0200, Axel Hecht wrote: > I've looked a bit deeper into the code, and there's unused > functionality that I'd like to rip out of JarMaker.py in favor of > this: > > Support for multiple jars in one go is one thing I'd love to axe. > I've probably added that thin

Re: try: -p all considered harmful?

2012-10-03 Thread Ben Hearsum
On 10/03/12 07:33 AM, Mounir Lamouri wrote: > On 09/29/2012 06:40 PM, Gavin Sharp wrote: >> On Sat, Sep 29, 2012 at 7:53 AM, Chris AtLee wrote: >>> http://people.mozilla.org/~catlee/highscores/highscores.html is a report of >>> where our time on Try is going. >> >> I think we should have this data

Re: Extending jar.mn to support cross-module overrides

2012-10-03 Thread Axel Hecht
I've looked a bit deeper into the code, and there's unused functionality that I'd like to rip out of JarMaker.py in favor of this: Support for multiple jars in one go is one thing I'd love to axe. I've probably added that thinking we could one day just fire one jarmaker for all of a language p

Re: try: -p all considered harmful?

2012-10-03 Thread Mounir Lamouri
On 09/29/2012 06:40 PM, Gavin Sharp wrote: > On Sat, Sep 29, 2012 at 7:53 AM, Chris AtLee wrote: >> http://people.mozilla.org/~catlee/highscores/highscores.html is a report of >> where our time on Try is going. > > I think we should have this data feed into a cronjob that emails the > top ~5 week

Re: NS_New$THING vs. new $THING

2012-10-03 Thread Neil
Nathan Froyd wrote: IMHO, the current state of affairs for bug 792169 is a little ugly, insofar as you do: #include "nsArray.h" ... nsCOMPtr = nsArray::Create(); ... I can certainly see the advantages of #include "nsIMutableArray.h" ... nsCOMPtr array = NewIArray(); [I'm assuming here