Re: try: -p all considered harmful?

2012-09-28 Thread Chris Pearce
On 29/09/12 14:32, L. David Baron wrote: On Friday 2012-09-28 22:16 -0400, Boris Zbarsky wrote: On 9/28/12 10:03 PM, Seth Fowler wrote: On Sep 28, 2012, at 6:28 PM, Boris Zbarsky wrote: The point is that the patches that _do_ need to land urgently are blocked on lack of resources because pe

Re: try: -p all considered harmful?

2012-09-28 Thread Kannan Vijayan
On 12-09-28 10:03 PM, Seth Fowler wrote: On Sep 28, 2012, at 6:28 PM, Boris Zbarsky wrote: The point is that the patches that _do_ need to land urgently are blocked on lack of resources because people are wasting too many cycles with unnecesary try pushes. This sounds like a notion of prior

Re: try: -p all considered harmful?

2012-09-28 Thread L. David Baron
On Friday 2012-09-28 22:16 -0400, Boris Zbarsky wrote: > On 9/28/12 10:03 PM, Seth Fowler wrote: > >On Sep 28, 2012, at 6:28 PM, Boris Zbarsky wrote: > > > >>The point is that the patches that _do_ need to land urgently are blocked > >>on lack of resources because people are wasting too many cycl

Re: try: -p all considered harmful?

2012-09-28 Thread Boris Zbarsky
On 9/28/12 10:03 PM, Seth Fowler wrote: On Sep 28, 2012, at 6:28 PM, Boris Zbarsky wrote: The point is that the patches that _do_ need to land urgently are blocked on lack of resources because people are wasting too many cycles with unnecesary try pushes. This sounds like a notion of prior

Re: try: -p all considered harmful?

2012-09-28 Thread Seth Fowler
On Sep 28, 2012, at 6:28 PM, Boris Zbarsky wrote: > The point is that the patches that _do_ need to land urgently are blocked on > lack of resources because people are wasting too many cycles with unnecesary > try pushes. This sounds like a notion of priority might be helpful. - Seth

Re: try: -p all considered harmful?

2012-09-28 Thread Boris Zbarsky
On 9/28/12 8:32 PM, Chris Pearce wrote: This is indeed unfortunate. However I'd prefer to add more capacity to our test infrastructure, rather than discourage developers from properly testing before landing. I think the concern is the definition of "properly". If Try is hogging resources need

Re: try: -p all considered harmful?

2012-09-28 Thread Steve Fink
On 09/28/2012 03:42 AM, Bobby Holley wrote: On that note, it would be nice if trychooser could implement some kind of |-p any| syntax that would select a platform with the fastest turnaround time and lowest load. This would save developers from manually doing such round-robin scheduling between l

Re: try: -p all considered harmful?

2012-09-28 Thread Chris Pearce
On 28/09/12 22:42, Bobby Holley wrote: Hi All, I'd like to propose that we discourage the use of all-platform try builds. I cringe a little bit every time I see a full column of orange on a try push. You should rejoice, for a full column of orange on Inbound was avoided! This is why we have

Josh Matthews is now a peer of private browsing

2012-09-28 Thread Ehsan Akhgari
Howdy all, Josh Matthews has been helping a lot with the per-window private browsing implementation that we have in the works. Throughout this effort, I believe he has come to learn more about our private browsing implementation than myself, so it's long overdue to announce him as the peer of the

Re: try: -p all considered harmful?

2012-09-28 Thread L. David Baron
On Friday 2012-09-28 16:34 -0400, Justin Lebar wrote: > I think adding |-p any| plus explicit acknowledging that a green -p > any build is sufficient testing to push non-platform-specific patches > to m-i could have a positive impact on our resource usage without > causing devs or sheriffs too much

Re: try: -p all considered harmful?

2012-09-28 Thread Justin Lebar
> If there are issues on that platform, no further platforms are scheduled. How do you define "issues"? Does "issues" mean "any orange"? At the moment, determining the difference between intermittent and perma-orange must be done by a human. We have no algorithms for doing so automatically. Th

Re: try: -p all considered harmful?

2012-09-28 Thread Ehsan Akhgari
On 2012-09-28 1:37 PM, Seth Fowler wrote: I am new to the use of the try build system and so this is not a suggestion informed by much experience with this particular setup, but time spent in other environments has shown me that running these sorts of test builds on all platforms can sometimes

Re: mach has landed

2012-09-28 Thread Gary Kwong
Win7 x64 / i7@3.9GHz / 8 cores / 12GB@1600MHz / SSD mirrored, warm clobbered build of debug desktop browser: -j12: 19m00s exactly -j9: 18m45s exactly Using more processes then cores is counter productive. I checked this 2 years ago already when build took just 13 minutes (we grow!!). Conclusio

Gfx meeting, Monday 2:30 PM US/Pacific

2012-09-28 Thread Benoit Jacob
Hello, The Graphics meeting will take place this Monday at 2:30 PM US/Pacific time. That could be Tuesday in your timezone. Please first add your agenda items there: https://wiki.mozilla.org/Platform/GFX/2012-October-1 * Every Monday at 2:30 PM Pacific Time * +1 650 903 0800 x92 Conf# 99366 * +

Re: What is the best way to keep track of all the window objects in a content window?

2012-09-28 Thread Dave Townsend
On 09/28/12 11:08, Paul Rouget wrote: In the Developer Tools, we often need to get a list of all the windows present in a page. (main window, iframes, iframes in iframes, …). We also need to be notified when a new window is created (createElement("iframe")). The naive way to do it: - recursivel

Re: What is the best way to keep track of all the window objects in a content window?

2012-09-28 Thread Paul Rouget
Paul Rouget wrote: > In the Developer Tools, we often need to get a list of all the windows present > in a page. (main window, iframes, iframes in iframes, …). > We also need to be notified when a new window is created > (createElement("iframe")). > > The naive way to do it: > - recursively go th

What is the best way to keep track of all the window objects in a content window?

2012-09-28 Thread Paul Rouget
In the Developer Tools, we often need to get a list of all the windows present in a page. (main window, iframes, iframes in iframes, …). We also need to be notified when a new window is created (createElement("iframe")). The naive way to do it: - recursively go throught the iframes via the DOM -

Re: mach has landed

2012-09-28 Thread Gregory Szorc
On 9/28/2012 8:49 AM, Mike Hommey wrote: On Fri, Sep 28, 2012 at 05:45:00PM +0200, Mike Hommey wrote: On Fri, Sep 28, 2012 at 05:34:09PM +0200, Honza Bambas wrote: On 9/28/2012 12:58 PM, Mike Hommey wrote: On Fri, Sep 28, 2012 at 06:45:24AM -0400, Benoit Jacob wrote: 2012/9/28 Aryeh Gregor :

Re: try: -p all considered harmful?

2012-09-28 Thread Seth Fowler
I am new to the use of the try build system and so this is not a suggestion informed by much experience with this particular setup, but time spent in other environments has shown me that running these sorts of test builds on all platforms can sometimes be quite useful. I'd suggest a variation on

Re: mach has landed

2012-09-28 Thread Mike Hommey
On Fri, Sep 28, 2012 at 05:45:00PM +0200, Mike Hommey wrote: > On Fri, Sep 28, 2012 at 05:34:09PM +0200, Honza Bambas wrote: > > On 9/28/2012 12:58 PM, Mike Hommey wrote: > > >On Fri, Sep 28, 2012 at 06:45:24AM -0400, Benoit Jacob wrote: > > >>2012/9/28 Aryeh Gregor : > > >>>On Thu, Sep 27, 2012 at

Re: mach has landed

2012-09-28 Thread Mike Hommey
On Fri, Sep 28, 2012 at 05:34:09PM +0200, Honza Bambas wrote: > On 9/28/2012 12:58 PM, Mike Hommey wrote: > >On Fri, Sep 28, 2012 at 06:45:24AM -0400, Benoit Jacob wrote: > >>2012/9/28 Aryeh Gregor : > >>>On Thu, Sep 27, 2012 at 6:08 PM, Gregory Szorc wrote: > I actually held out on you with t

Re: mach has landed

2012-09-28 Thread Honza Bambas
On 9/28/2012 12:58 PM, Mike Hommey wrote: On Fri, Sep 28, 2012 at 06:45:24AM -0400, Benoit Jacob wrote: 2012/9/28 Aryeh Gregor : On Thu, Sep 27, 2012 at 6:08 PM, Gregory Szorc wrote: I actually held out on you with the initial landing of mach: there is more advanced tree building code in the

Re: "ERROR: Logon failure: unknown user name or bad password." on mochitests

2012-09-28 Thread Armen Zambrano G.
Thanks Clint. For now, IT managed to re-imaged most of the ill slaves and they will try to find out what the root cause was to prevent it from happening in the future. cheers, Armen On 12-09-27 1:06 PM, Clint Talbert wrote: On 9/27/2012 6:52 AM, Armen Zambrano G. wrote: On 12-09-27 7:03 AM,

Re: try: -p all considered harmful?

2012-09-28 Thread Ben Hearsum
On 09/28/12 06:42 AM, Bobby Holley wrote: > On that note, it would be nice if trychooser could implement some kind of > |-p any| syntax that would select a platform with the fastest turnaround > time and lowest load. This would save developers from manually doing such > round-robin scheduling betwe

Re: mach has landed

2012-09-28 Thread Mike Hommey
On Fri, Sep 28, 2012 at 06:45:24AM -0400, Benoit Jacob wrote: > 2012/9/28 Aryeh Gregor : > > On Thu, Sep 27, 2012 at 6:08 PM, Gregory Szorc wrote: > >> I actually held out on you with the initial landing of mach: there is more > >> advanced tree building code in the pipes, complete with progress

Re: mach has landed

2012-09-28 Thread Benoit Jacob
2012/9/28 Aryeh Gregor : > On Thu, Sep 27, 2012 at 6:08 PM, Gregory Szorc wrote: >> I actually held out on you with the initial landing of mach: there is more >> advanced tree building code in the pipes, complete with progress indicators. >> However, getting it reviewed is a challenge because we w

try: -p all considered harmful?

2012-09-28 Thread Bobby Holley
Hi All, I'd like to propose that we discourage the use of all-platform try builds. I cringe a little bit every time I see a full column of orange on a try push. More often than not, it means that we spent an order of magnitude extra compute time verifying that, indeed, the push caused a given tes

Re: mach has landed

2012-09-28 Thread Aryeh Gregor
On Thu, Sep 27, 2012 at 6:08 PM, Gregory Szorc wrote: > I actually held out on you with the initial landing of mach: there is more > advanced tree building code in the pipes, complete with progress indicators. > However, getting it reviewed is a challenge because we want the build system > integra