Re: Switching nsnull to nullptr

2012-07-25 Thread Dave Mandelin
On Wednesday, July 25, 2012 2:19:43 PM UTC-7, Ehsan Akhgari wrote: > On 12-07-25 1:45 PM, Dave Mandelin wrote: > > On Wednesday, July 25, 2012 7:45:43 AM UTC-7, Bobby Holley wrote: > >> On Wed, Jul 25, 2012 at 4:21 PM, Aryeh Gregor wrote: > >> > >> > On Wednesday, July 25, 2012 3:04:31 PM UTC+3,

Re: Switching nsnull to nullptr

2012-07-25 Thread Ehsan Akhgari
On 12-07-25 1:02 PM, Chris Peterson wrote: gcc did not add nullptr until gcc 4.6. For gcc <= 4.5 (like Android's gcc 4.4), we should consider using gcc's magic __null: #define nullptr __null Also, gcc 4.7 added a new -Wzero-as-null-pointer-constant warning to flag uses of literal 0 as a poin

Re: Switching nsnull to nullptr

2012-07-25 Thread Ehsan Akhgari
On 12-07-25 1:45 PM, Dave Mandelin wrote: On Wednesday, July 25, 2012 7:45:43 AM UTC-7, Bobby Holley wrote: On Wed, Jul 25, 2012 at 4:21 PM, Aryeh Gregor wrote: > On Wednesday, July 25, 2012 3:04:31 PM UTC+3, Justin Lebar wrote: > > > The next step is to s/nsnull/nullptr/ in the codebase, an

Re: Switching nsnull to nullptr

2012-07-25 Thread Dave Mandelin
On Wednesday, July 25, 2012 7:45:43 AM UTC-7, Bobby Holley wrote: > On Wed, Jul 25, 2012 at 4:21 PM, Aryeh Gregor wrote: > > > On Wednesday, July 25, 2012 3:04:31 PM UTC+3, Justin Lebar wrote: > > > > The next step is to s/nsnull/nullptr/ in the codebase, and > get rid > > of nsnull. > > > > >

Re: Switching nsnull to nullptr

2012-07-25 Thread Chris Peterson
gcc did not add nullptr until gcc 4.6. For gcc <= 4.5 (like Android's gcc 4.4), we should consider using gcc's magic __null: #define nullptr __null Also, gcc 4.7 added a new -Wzero-as-null-pointer-constant warning to flag uses of literal 0 as a pointer (in C++ code). We could enable this wa

Re: Switching nsnull to nullptr

2012-07-25 Thread Bobby Holley
On Wed, Jul 25, 2012 at 4:21 PM, Aryeh Gregor wrote: > On Wednesday, July 25, 2012 3:04:31 PM UTC+3, Justin Lebar wrote: > > > The next step is to s/nsnull/nullptr/ in the codebase, and get rid > of nsnull. > > > > Forgive my ignorance, but how does this affect NULL? Would that be > > deprecated

Re: Switching nsnull to nullptr

2012-07-25 Thread Aryeh Gregor
On Wednesday, July 25, 2012 3:04:31 PM UTC+3, Justin Lebar wrote: > > The next step is to s/nsnull/nullptr/ in the codebase, and get rid of > nsnull. > > Forgive my ignorance, but how does this affect NULL? Would that be > deprecated in favor of nullptr as well? Should we use nsnull instead > o

Snappy Meeting, Thurs. July 26, 11am PT

2012-07-25 Thread Lawrence Mandel
Colin Greenwood said [1], "The guitar is a much more efficient machine than a computer. More responsive." Discuss. And, join us this Thursday, 11am PT, to discuss Firefox responsiveness. Please add your items and status to the agenda before the call. https://etherpad.mozilla.org/snappy Dial-in:

Re: Switching nsnull to nullptr

2012-07-25 Thread Justin Lebar
> The next step is to s/nsnull/nullptr/ in the codebase, and get rid of nsnull. Forgive my ignorance, but how does this affect NULL? Would that be deprecated in favor of nullptr as well? Should we use nsnull instead of NULL in new code, in anticipation of the nsnull --> nullptr switch? -Justin

Switching nsnull to nullptr

2012-07-25 Thread Aryeh Gregor
The C++11 standard defines a new dedicated null-pointer symbol, "nullptr". It provides better type-safety than existing null-pointer definitions, because it doesn't allow implicit conversion to numeric types. In I defined "nullptr" to mean

Re: Disabling tests

2012-07-25 Thread Dao
On 25.07.2012 02:05, ben turner wrote: Disabling a test without a peer's input and then leaving open an unassigned bug to re-enable it is a pretty good way to leave the test disabled forever. Seems like somebody should be watching the component and take care of the bug. If this doesn't happen,

Re: Disabling tests

2012-07-25 Thread simetrical
On Wednesday, July 25, 2012 3:05:07 AM UTC+3, bent wrote: > However, I firmly believe that disabling a randomly-failing test is a > decision that should be made by the module owners and peers. > > Perhaps it's only a recent development but I've seen my OOP test suite > for IndexedDB disabled twice

Re: Disabling tests

2012-07-25 Thread Ms2ger
On 07/25/2012 02:05 AM, ben turner wrote: Peers can make the decision if it's worth disabling a test, pull someone off of other tasks to fix it, or whatever. Or in this case you claim that wasting sheriffs' time is much less important than your vacation / other tasks, as you did in the bug.