Re: PSA: |mach python-test| can now run with python 3

2018-07-13 Thread Gregory Szorc
On Fri, Jul 6, 2018 at 3:12 AM, Axel Hecht wrote: > Nice. > > I'm just devoting my Friday productivity to fixing bustages in python 3.7 > compared to 3.6. Which affect code I copied from mozpack.path ;-) [0] > > Which leads me to: We should run tests in automation for at least 3.7 and > 3.6. Not

Re: PSA: |mach python-test| can now run with python 3

2018-07-06 Thread Andrew Halberstadt
I was about to double-down on my earlier assertion that it wasn't worth it at this point in time (while agreeing that we would do it in the ideal case). But it looks like Pipenv automatically installs a version of python via pyenv already if you specify it with --python. E.g: pipenv --python 3.7 i

Re: PSA: |mach python-test| can now run with python 3

2018-07-06 Thread Axel Hecht
Am 06.07.18 um 16:04 schrieb Dustin Mitchell: I agree -- we faced similar issues in the days when py2.5 - 2.7 were still available. I think that if we're clear about the Python version we test on in CI, and willing to make the effort to fix bugs when we change that (e.g., to 3.8), that's suffici

Re: PSA: |mach python-test| can now run with python 3

2018-07-06 Thread Dustin Mitchell
I agree -- we faced similar issues in the days when py2.5 - 2.7 were still available. I think that if we're clear about the Python version we test on in CI, and willing to make the effort to fix bugs when we change that (e.g., to 3.8), that's sufficient. Dustin ___

Re: PSA: |mach python-test| can now run with python 3

2018-07-06 Thread Andrew Halberstadt
That bug makes me sad. Right now the tests just use whatever version of python 3 is installed on the system. Expanding them to run on multiple versions of python 3 would likely mean doing our own bootstrapping with pyenv or the like. Tbh, I think our efforts would be better spent getting things w

Re: PSA: |mach python-test| can now run with python 3

2018-07-06 Thread Axel Hecht
Nice. I'm just devoting my Friday productivity to fixing bustages in python 3.7 compared to 3.6. Which affect code I copied from mozpack.path ;-) [0] Which leads me to: We should run tests in automation for at least 3.7 and 3.6. Not sure what still ships 3.5, if at all? Testing some version

Re: PSA: |mach python-test| can now run with python 3

2018-07-03 Thread David Burns
This is really exciting news! David On 3 July 2018 at 16:48, Andrew Halberstadt wrote: > Dave Hunt has recently landed a lot of great work to get > some of our python unittests running with Python 3. You > can see his blog post on it here: > http://davehunt.co.uk/2018/06/29/python-unit-tests-no

PSA: |mach python-test| can now run with python 3

2018-07-03 Thread Andrew Halberstadt
Dave Hunt has recently landed a lot of great work to get some of our python unittests running with Python 3. You can see his blog post on it here: http://davehunt.co.uk/2018/06/29/python-unit-tests-now-running-with-python-3-at-mozilla.html The march to Python 3 has been long and slow, but this is