Re: Intent to require Python 3 to build Firefox 59 and later

2018-04-03 Thread Gregory Szorc
On Fri, Nov 10, 2017 at 3:27 PM, Gregory Szorc wrote: > For reasons outlined at https://bugzilla.mozilla.org/s > how_bug.cgi?id=1388447#c7, we would like to make Python 3 a requirement > to build Firefox sometime in the Firefox 59 development cycle. (Firefox 59 > will be an ESR release.) > > The

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-16 Thread Rok Garbas
It would make my heart sing if all python 3 code we write would have defined types (using mypy in in ./mach lint). It would definitely remove the feeling of "walking blindfolded" when doing any change with the python tooling. At least I hope providing types would be allowed if not required. -- Rok

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread AllassoPraise
Hello, When trying to do non-archive build on Linux I get error: 29:57.52Compiling style v0.0.1 (file:///home/allasso/mozilla-central/mozilla-central_3/servo/components/style) 29:57.52 error[E0106]: missing lifetime specifier This is after successfully running mach bootstrap. Here is my con

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread Gregory Szorc
On Mon, Nov 13, 2017 at 5:22 PM, Kevin Jones wrote: > I have python2.7, python3.5, and python (which links to 2.7) on my linux > machine. Will mach build sort this out and know which version to use for > what? > That is the recommend binary naming convention for Python binaries. The build syste

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread AllassoPraise
I have python2.7, python3.5, and python (which links to 2.7) on my linux machine. Will mach build sort this out and know which version to use for what? Also, on OS X I only have 2.7, so I assume I'll have to install 3.x using port. What variable do I need to set in my mozconfig to tell mach bui

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread Jeff Gilbert
As long as we follow PEP 394, I'm super excited. (including on our mozilla-build windows system, which counts as 'unix-like') On Sun, Nov 12, 2017 at 9:12 AM, David Burns wrote: > I am not saying it should but if we have a requirement for python 3, we are > also going to have a requirement for py

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread Dustin Mitchell
There will come a point very soon when working on Python 2 code is about as attractive as working on Perl (sorry, Perl afficionados!). So this effort will get us to the point where heavily-developed things run in Python 3, less-heavily-develped stuff is at least "ready to port" (ensured via variou

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread Gregory Szorc
On Mon, Nov 13, 2017 at 5:22 AM, Ted Mielczarek wrote: > On Sun, Nov 12, 2017, at 12:12 PM, David Burns wrote: > > I am not saying it should but if we have a requirement for python 3, we > are also going to have a requirement for py2 to both be available for local > development. > > > Correct, an

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-13 Thread Ted Mielczarek
On Sun, Nov 12, 2017, at 12:12 PM, David Burns wrote: > I am not saying it should but if we have a requirement for python 3, > we are also going to have a requirement for py2 to both be available > for local development. Correct, and as far as I know that's the plan of record. As Greg said, we're n

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-12 Thread David Burns
I am not saying it should but if we have a requirement for python 3, we are also going to have a requirement for py2 to both be available for local development. David On 11 November 2017 at 14:10, Andrew Halberstadt wrote: > On Fri, Nov 10, 2017 at 9:44 PM David Burns wrote: > >> My only conce

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-11 Thread Andrew Halberstadt
On Fri, Nov 10, 2017 at 9:44 PM David Burns wrote: > My only concern about this is how local developer environments are going > to be when it comes to testing. While I am sympathetic to moving to python > 3 we need to make sure that all the test harnesses have been moved over and > this is someth

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-10 Thread Andreas Tolfsen
Also sprach Gregory Szorc: The requirement will likely be Python 3.5+. Although I would love to make that 3.6 if possible so we can fully harness modern features and performance. Hold your horses with 3.6. Only Python 3.5.3 is at the time of writing available in the most common Linux distribu

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-10 Thread David Burns
My only concern about this is how local developer environments are going to be when it comes to testing. While I am sympathetic to moving to python 3 we need to make sure that all the test harnesses have been moved over and this is something that needs a bit of coordination. Luckily a lot of the mo

Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-10 Thread Adam Moore
The current Ubuntu LTS release has 3.5.2, I wouldn't try to force 3.6. On Fri, Nov 10, 2017 at 3:46 PM, Adam Moore wrote: > The current Ubuntu LTS release has 3.5.2, I wouldn't try to force 3.6. > > On Fri, Nov 10, 2017 at 3:27 PM, Gregory Szorc wrote: > >> For reasons outlined at >> https://bu

Intent to require Python 3 to build Firefox 59 and later

2017-11-10 Thread Gregory Szorc
For reasons outlined at https://bugzilla.mozilla.org/show_bug.cgi?id=1388447#c7, we would like to make Python 3 a requirement to build Firefox sometime in the Firefox 59 development cycle. (Firefox 59 will be an ESR release.) The requirement will likely be Python 3.5+. Although I would love to mak