Re: [apache/tvm] [RFC][Tracking Issue][AMP] Tracking Issue for Mixed Precision Pass (#8296)

2021-09-03 Thread masahi
@AndrewZhaoLuo What is our goal wrt mixed_type accumulation? Assuming we do find cases where mixed accum is beneficial, how are we going to decide when to enable / disable it? Given that currently we can only choose one or the other per op, https://github.com/apache/tvm/blob/f4f525dab86af653636

[apache/tvm] [VOTE] Incorporate New Code Review Guideline (#8928)

2021-09-03 Thread Tianqi Chen
Dear Community: This is a formal vote to adopt the proposed improvements to the code review guidelines. Please see the proposed improvements here https://discuss.tvm.apache.org/t/improve-code-review-guideline/10898 This is a formal voting thread for the community to adopt the improvements. P

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread masahi
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912825798

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Wuwei Lin
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912827349

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Cody Yu
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912831757

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Denise Kutnick
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912836919

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Matt Welsh (OctoML)
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912837276

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Xiyou Zhou
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912850347

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Thierry Moreau
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912857109

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Lily Orth-Smith
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912869690

Re: [apache/tvm] [VOTE] Adopt New Code Review Guideline (#8928)

2021-09-03 Thread Yuchen Jin
+1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/8928#issuecomment-912871890