Re: [apache/tvm-rfcs] [RFC] Adding initial SVE implementation (#18)

2021-09-01 Thread sjoerdmeijer
@masahi, about: > If possible, I think it is better not to introduce user facing changes, since > as far as an API is concerned, `s[C].vectorize(...)` is already vector-length > agnostic. which I think is very closely related to an earlier inline comment: > As I commented above, I'd like to

Re: [apache/tvm-rfcs] Additional Target Hooks RFC (#10)

2021-09-01 Thread Mark Shields
This LGTM but I'm thinking going back to relay_to_tir being a Function->PrimFunc packed func as you implemented in the companion PR is better since it makes it easier for all the caching, call rewriting, dynamic shape handling and other bookkeeping to be shared. Have you tried out the pass appr

[apache/tvm-rfcs] RFC for TVM Documentation Refactoring (#27)

2021-09-01 Thread Chris Hoge
You can view, comment on, or merge this pull request online at: https://github.com/apache/tvm-rfcs/pull/27 -- Commit Summary -- * RFC for TVM Documentation Refactoring -- File Changes -- A rfcs/00xx-refactor-docs.md (430) -- Patch Links -- https://github.com/apache/tvm-rfcs/pull/27.

Re: [apache/tvm-rfcs] [RFC] Adding initial SVE implementation (#18)

2021-09-01 Thread masahi
Thanks @sjoerdmeijer @giuseros, I didn't imagine that there would be a case where mixing fixed and scalable vectorization is beneficial. I prefer `s[C].vectorize(..., scalable=True)` to `s[C].vectorize_scalable(...)` but both seem fine. Any other comments @tqchen @tkonolige? -- You are receiv

Re: [apache/tvm-rfcs] RFC for TVM Documentation Refactoring (#27)

2021-09-01 Thread 黄若辰
unsubsribe On 09/01/2021 15:06, Chris Hoge wrote: You can view, comment on, or merge this pull request online at: https://github.com/apache/tvm-rfcs/pull/27 -- Commit Summary -- * RFC for TVM Documentation Refactoring -- File Changes -- A rfcs/00xx-refactor-docs.md (430) -- Patch Li

Re: [apache/tvm-rfcs] RFC for TVM Documentation Refactoring (#27)

2021-09-01 Thread 黄若辰
cancel On 09/01/2021 16:56, 黄若辰 wrote: unsubsribe On 09/01/2021 15:06, Chris Hoge wrote: You can view, comment on, or merge this pull request online at: https://github.com/apache/tvm-rfcs/pull/27 -- Commit Summary -- * RFC for TVM Documentation Refactoring -- File Changes -- A rfcs/

Re: [apache/tvm-rfcs] [RFC]PyTorchTVM (#25)

2021-09-01 Thread Junru Shao
@Meteorix Thanks for your responds! I just updated the comments according to your feedback. Don't hesitate to ping me if you need any inputs. Thanks a lot! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/a

RE: [apache/tvm-rfcs] [RFC]PyTorchTVM (#25)

2021-09-01 Thread ZHENG Jianwei
Unsubscribe Sent from Mail for Windows From: Junru Shao Sent: Thursday, September 2, 2021 10:40 AM To: apache/tvm-rfcs Cc: Subscribed