Merged #8 into main.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/8#event-5111983679
@Mousius @mehrdadh @tkonolige @guberti please take another look and
https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://githu
@Mousius @tqchen please take a look
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/8#issuecomment-889484620
@tkonolige @guberti @mehrdadh please take another look and explicitly approve
if you're good w/ this
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/8#issuecomment-887894876
@Mousius please take another look when you can and explicitly approve!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/8#issuecomment-887879286
>> On generate_project method, and considering TVMC, my only comment is that it
>> should allow a project creation based also on MLF .tar, instead of only a
>> "live" executor.
>I agree; let's merge additional logic in project.py to do this as follow-on to
>this impl.
Sure! I'll submit a follow
Thanks @Mousius @gromero for your comments. updated the RFC to reflect
accurately on PoC now that it seems to be passing regression. Please take
another look so we can merge this and proceed forward with Project API.
@gromero some follow-ups on your comments:
> On generate_project method, and co
@mdw-octoml would be great to get your feedback here as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/8#issuecomment-871810453
