+1
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/16368#issuecomment-1882435712
You are receiving this because you are subscribed to this thread.
Message ID:
+1
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/15521#issuecomment-1679372917
You are receiving this because you are subscribed to this thread.
Message ID:
+1, thanks @AndrewZhaoLuo!
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/13026#issuecomment-1275243321
You are receiving this because you are subscribed to this thread.
Message ID:
+1
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12743#issuecomment-1245721784
You are receiving this because you are subscribed to this thread.
Message ID:
+1
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12651#issuecomment-1233388156
You are receiving this because you commented.
Message ID:
0
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/12583#issuecomment-1232311473
You are receiving this because you are subscribed to this thread.
Message ID:
+1
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/11415#issuecomment-1141604024
You are receiving this because you are subscribed to this thread.
Message ID:
Hi, would you please retrigger the CI by sending an empty commit?
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/10308#issuecomment-1049605201
You are receiving this because you are subscribed to this thread.
Message ID:
Thanks for the RFC. Generally I am in support of the change.
- Moving the config to IRModule could better avoid overloading the target.
- The design of targets list and target host seems really similar to a
composite target, can we actually use a single composite target (where each
target can b
+1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/8928#issuecomment-912850347
I do agree that we don’t want abstractions that are not useful.
Just to explain a bit more: any op could have both legalization and intrinsic
lowering function. Type-wise, yes they are all TIR expressions and technically
there’s no difference. Concept-wise, since any op can have both implement
So technically I don’t think they are very different in behavior, i.e., the
type of functions are the same in TIR. It’s more of a conceptual difference for
now.
---
[Visit
Topic](https://discuss.tvm.apache.org/t/is-there-a-difference-between-lower-and-legalize-in-tir/10714/5)
to respond.
Legalization is when there is no available op intrinsic lowering function
available, we might use other op to combine and implement some op. For example,
[here](https://github.com/apache/tvm/blob/3d380fc5817ce335ea823ce7e6b7e35717e579cd/src/target/llvm/intrin_rule_llvm.cc#L106)
the exp10 op on
Hi, good catch! They are designed to deal with op intrinsic lowering and op
legalization respectively in the lowering pass. Ideally, we always want to use
intrinsic lowering before legalization if available. I don't think we are going
to phase out any of them for now because there could be div
+1
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/issues/7991#issuecomment-837422559
Good point. It's a lot more clear. I'll adopt in the PR.
---
[Visit
Topic](https://discuss.tvm.apache.org/t/new-target-intrinsic-lowering-and-legalization-mechanism/9683/3)
to respond.
You are receiving this because you enabled mailing list mode.
To unsubscribe from these emails, [click
Follow up on my previous PR on supporting the new target system with
`target_host` folded into the target object. I have submitted a new PR on
review https://github.com/apache/tvm/pull/7534 this week to **fully support all
functions** previously using target and target_host as argument with ba
17 matches
Mail list logo
