Thanks @driazati! LGTM!
@areusch
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1195513761
You are receiving this because you are subscribed to this thread.
Message ID:
This issue is to track progress for `Name mangling in IRModules`
PR: #12066
RFC discussion: https://github.com/apache/tvm-rfcs/pull/84
Forum:
https://discuss.tvm.apache.org/t/pre-rfc-name-mangling-in-irmodules/12944/7
--
Reply to this email directly or view it on GitHub:
https://github.com/apac
> @gigiblender is this ready for a last review?
@areusch yes
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/84#issuecomment-1193604132
You are receiving this because you are subscribed to this thread.
Message ID:
> @gigiblender could you review this one so you can understand how this tool
> works?
@areusch Sure
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm/pull/11938#issuecomment-1193596507
You are receiving this because you are subscribed to this thread.
Message I
Adding a [draft PR](https://github.com/apache/tvm/pull/12066) to this
discussion.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/84#issuecomment-1181766176
You are receiving this because you are subscribed to this thread.
Message ID:
> A couple of thoughts...
>
> * We should have a common facility that represents a scope in which names
> need to be unique. Conceptually it could be a set of "known" strings (that
> are presumed used), and something (like a private counter) to generate a
> unique suffix. The use would be
> Thanks @gigiblender ! a few points for consideration:
>
> * Ideally NameSupply should interact well with our current linkage spec,
> e.g. if a function have an attribute `global_symbol`, it means the name is
> "final"(because external users are expecting to look it up with that name),
> l
[Rendered](https://github.com/gigiblender/tvm-rfcs/blob/mangling-rfc/rfcs/0077_name_mangling_ir_modules.md)
You can view, comment on, or merge this pull request online at:
https://github.com/apache/tvm-rfcs/pull/84
-- Commit Summary --
* [RFC] RFC-name-mangling-ir-modules
-- File Changes --
