Re: [apache/tvm-rfcs] [RFC] Adding initial SVE implementation (#18)

2021-10-11 Thread Tianqi Chen
@kparzysz-quic this is right. On the other hand, we still on conversion of DLDataType and DataType(e.g. getting DataType from ndarray) in many cases. So ideally we want to keep them consistent -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

Re: [apache/tvm-rfcs] [RFC] Adding initial SVE implementation (#18)

2021-10-11 Thread Krzysztof Parzyszek
Right, but users of DLPack will not see `DataType`, only `DLDataType`, unless they use TVM as well. Changing `DataType` will only affect those that use `include/tvm/runtime/data_type.h` (i.e. the ABI breakage will be limited to users of TVM). -- You are receiving this because you are subscrib

Re: [apache/tvm-rfcs] [RFC] Adding initial SVE implementation (#18)

2021-10-11 Thread Tianqi Chen
@kparzysz-quic DatatType is a thin wrapper around DLDataType -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/18#issuecomment-940227361

Re: [apache/tvm-rfcs] [RFC] Adding initial SVE implementation (#18)

2021-10-11 Thread Krzysztof Parzyszek
> DataType and DLDataType are part of DLPack standard, The `DataType` type is defined in TVM, it's not present in DLPack. Or am I missing something? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache