[TVM Discuss] [Development/RFC] [RFC][Relay] Program Matching for Relay Pt 1: A pattern language

2020-04-24 Thread Matthew Brookhart via TVM Discuss
In particular: 1. The Dominator pattern adds some fuzziness to the pattern matching that is non-standard for graph pattern matchers. It provides a way to find something like a convolution op, who's output is then used by several elementwise ops, that are then combined together. This kind of fe

Re: [apache/incubator-tvm] [RFC] AlterOpLayout Pass Refactoring (#3670)

2020-04-24 Thread Yizhi Liu
@mbrookhart not at all, please feel free to proceed :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-tvm/issues/3670#issuecomment-619263443

Re: [apache/incubator-tvm] [RFC] AlterOpLayout Pass Refactoring (#3670)

2020-04-24 Thread Matthew Brookhart
@yzhliu I've hit a couple of issue that would be completely solved by this change :). Any chance you've made progress? If not, would you be offended if I gave it a shot over the next few weeks? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

[TVM Discuss] [Development/RFC] [RFC][Relay] Program Matching for Relay Pt 1: A pattern language

2020-04-24 Thread Matthew Brookhart via TVM Discuss
Hi All, Thanks for all of the comments. The PR is complete, I've added the Partitioner we were planning on doing. Since some of the API's (especially around the dominator pattern) are somewhat novel, I'd appreciate anyone who can take a few minutes to look over the PR. Matthew --- [Visi

[TVM Discuss] [Development/RFC] Target and Attributes

2020-04-24 Thread Krzysztof Parzyszek via TVM Discuss
I'm a bit late to this, but here are my thoughts: The hardware string shouldn't be the only way to define target, it should be a convenient shortcut of a more complex definition. I think that's what **S0** does---we can maintain a mapping from a set of predefined hardware "keywords" into an

[TVM Discuss] [Development/RFC] [RFC] Conversion from std::string to tvm::runtime::String

2020-04-24 Thread tqchen via TVM Discuss
Here is a POC with update code for serialization compatibility https://github.com/apache/incubator-tvm/pull/5438 --- [Visit Topic](https://discuss.tvm.ai/t/rfc-conversion-from-std-string-to-tvm-string/6453/4) to respond. You are receiving this because you enabled mailing list mode. To u

[TVM Discuss] [Development/RFC] [RFC] MLIR Frontend

2020-04-24 Thread tqchen via TVM Discuss
My specific comment is under the context of the TVM's unfied IR infra, to elaborate further. The current TVM's new IR Infra incorporates three variants of functions in the same IRModule, tir::PrimFunc, relay::Function, and we will have additional ExternFunc for MLIR variants of that to repres

[TVM Discuss] [Development/RFC] [RFC] MLIR Frontend

2020-04-24 Thread yunjing_lh via TVM Discuss
Thank you for bringing up this great proposal! Like @yangjunpro mentioned, we at Alibaba, along with @lfengad @dingli have move along this direction for quite some time now. We choose GraphDef->HLO->Relay for the exact same reasons, that it is a stable and concise IR to work on. Glad to be loo