Re: [dmlc/tvm] [RFC] Node Construction Style: Use Constructor When Possible (#3223)

2019-05-22 Thread Tianqi Chen
Some further thoughts: in many cases, a static factory function gives more information than a constructor. For example, ```NDArray::Empty``` is certainly better than just using NDArray's constructor. So we do want to keep static factory function if they are in reference types. Perhaps the usage

Re: [dmlc/tvm] [RFC] Node Construction Style: Use Constructor When Possible (#3223)

2019-05-22 Thread Tianqi Chen
Static factory function is fine. The only question is whether they should be in the Node class or the reference class itself. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/issues/3223#issuecomme

Re: [dmlc/tvm] [RFC] MISRA-C/C++ Compliant Runtime (#3159)

2019-05-22 Thread Liangfu Chen
If I understand correctly, using a fixed pre-allocated heap would lead us to convert a fragment of the storage pool (which is a fixed-sized static memory) into the specific data type for computation. This violates another rule that restrict (or avoid) using data type conversion. In this case, I

Podling Report Reminder - June 2019

2019-05-22 Thread jmclean
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 19 June 2019, 10:30 am PDT. The report for your podling will form a