Re: [dmlc/tvm] [Relay][RFC] Improve testing infrastructure of Relay (#2884)

2019-03-23 Thread Siva
Can we add weekly builds for end to end test cases which takes long hours ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/issues/2884#issuecomment-475932142

Re: [dmlc/tvm] [Relay][RFC] Improve testing infrastructure of Relay (#2884)

2019-03-23 Thread Tianqi Chen
Realistically, infrastructure is only one way to help making better regression tests but cannot ever replace regression tests. We do need and should write more testcases in the meanwhile :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [dmlc/tvm] [Relay][RFC] Improve testing infrastructure of Relay (#2884)

2019-03-23 Thread Zhi
+1 for refactoring. BTW, we probably also need to have some discussion about adding some regression tests in CI pipeline because some passes could noticeably affect perf. But this can be a separate issue. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [dmlc/tvm] [Relay][RFC] Improve testing infrastructure of Relay (#2884)

2019-03-23 Thread Steven S. Lyubomirsky
The test code has a lot of repetition and I am strongly in favor of refactoring existing tests (some of which show a fair bit of bitrot) to use common libraries. Testing error cases would also be a good thing to have shared infrastructure for. -- You are receiving this because you are subscrib

[dmlc/tvm] [Relay][RFC] Improving testing infrastructure of Relay (#2884)

2019-03-23 Thread 雾雨魔理沙
As an implementor of multiple passes in Relay, I had noticed that we have far too little test case. Most test_pass_*.py do not test for all program construct. For example, test_pass_dead_code_elimination do not test about adt, or test_pass_fuse_ops do not test about closure and reference. I had

Podling Report Reminder - April 2019

2019-03-23 Thread jmclean
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 17 April 2019, 10:30 am PDT. The report for your podling will form a

Re: [dmlc/tvm] [Relay][RFC] Automatic Differentiation (#2237)

2019-03-23 Thread 雾雨魔理沙
Closed #2237. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dmlc/tvm/issues/2237#event-2224611474