GitHub user wangyf2010 opened a pull request:
https://github.com/apache/tomcat/pull/22
[Bug 58242] Scanning jars in classpath to get annotations in parallel
instead of synchronously
During tomcat startup, it takes most of time on annotation scanning.
For our case, our apps have
Github user wangyf2010 commented on the pull request:
https://github.com/apache/tomcat/pull/22#issuecomment-131473216
Thanks for your comments, market!
Understood your concern, let me explain it one by one:
>The patch appears to be quite large for a marginal ben
Github user wangyf2010 commented on the pull request:
https://github.com/apache/tomcat/pull/22#issuecomment-131489980
>it is not thread safe (look at the Java class cache)
Please refer AnnotationScanningResult, it will fork a new instance for Java
class cache or maps, t
Github user wangyf2010 commented on the pull request:
https://github.com/apache/tomcat/pull/22#issuecomment-131649270
>My comment regarding separating the refactoring and the functional changes
stands. It is not the refactoring I am against, it is the mixing of refactoring