Re: [PR] Add a build test for windows. [tomcat-native]

2025-06-06 Thread via GitHub
jfclere commented on code in PR #26: URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132092619 ## .github/workflows/makefile.yml: ## @@ -0,0 +1,88 @@ +name: Makefile CI + +on: + push: +branches: [ "trunk" ] + pull_request: +branches: [ "trunk" ] Revi

Re: [PR] Add a build test for windows. [tomcat-native]

2025-06-06 Thread via GitHub
jfclere commented on code in PR #26: URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132055363 ## .github/workflows/makefile.yml: ## @@ -0,0 +1,88 @@ +name: Makefile CI + +on: + push: +branches: [ "trunk" ] + pull_request: +branches: [ "trunk" ] + +en

Re: [PR] Add a build test for windows. [tomcat-native]

2025-06-06 Thread via GitHub
jfclere commented on code in PR #26: URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132055363 ## .github/workflows/makefile.yml: ## @@ -0,0 +1,88 @@ +name: Makefile CI + +on: + push: +branches: [ "trunk" ] + pull_request: +branches: [ "trunk" ] + +en

Re: [PR] Add a build test for windows. [tomcat-native]

2025-06-06 Thread via GitHub
jfclere commented on code in PR #26: URL: https://github.com/apache/tomcat-native/pull/26#discussion_r2132091663 ## .github/workflows/makefile.yml: ## @@ -0,0 +1,88 @@ +name: Makefile CI + +on: + push: +branches: [ "trunk" ] + pull_request: +branches: [ "trunk" ] + +en

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
galkin-anton commented on PR #866: URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956256549 With this flag, the executor will be created in org.apache.tomcat.util.net.AbstractEndpoint#createExecutor -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
markt-asf commented on PR #866: URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956270535 If you want to set that property, use the `setProperty(String,String)` method. There are a lot of properties that are just passed through from the `Connector` to the `Endpoint`. Those prop

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
markt-asf commented on PR #866: URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956213892 What is the purpose of this change? It does not appear to be necessary. Further, the patch as provided includes an unnecessary semi-colon. -- This is an automated message from the

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
galkin-anton commented on PR #866: URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956246322 > What is the purpose of this change? It does not appear to be necessary. > > Further, the patch as provided includes an unnecessary semi-colon. In my case, I'd like to mana

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
galkin-anton commented on PR #866: URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956249452 I thought this patch would be useful to everyone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
galkin-anton opened a new pull request, #866: URL: https://github.com/apache/tomcat/pull/866 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
galkin-anton commented on PR #866: URL: https://github.com/apache/tomcat/pull/866#issuecomment-2956356313 Thank you for your advice. Then I reject pull request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] add set flag for use virtual threads by connector [tomcat]

2025-06-09 Thread via GitHub
galkin-anton closed pull request #866: add set flag for use virtual threads by connector URL: https://github.com/apache/tomcat/pull/866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] Bump org.apache:apache from 34 to 35 [tomcat-jakartaee-migration]

2025-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #77: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/77 Bumps [org.apache:apache](https://github.com/apache/maven-apache-parent) from 34 to 35. Release notes Sourced from https://github.com/apache/maven-apache-parent/release

<    16   17   18   19   20   21