[GitHub] tomcat pull request #:

2017-05-31 Thread powerYao
Github user powerYao commented on the pull request: https://github.com/apache/tomcat/commit/9b3dc6eb9baf00050ca486fa3d6227a6dd6af1af#commitcomment-22352684 look like good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] tomcat pull request #:

2017-05-31 Thread powerYao
Github user powerYao commented on the pull request: https://github.com/apache/tomcat/commit/dd401de453cd9503dd4f32e10e1f01e920754fd3#commitcomment-22352750 look like nothing is work --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] tomcat pull request #:

2017-06-02 Thread powerYao
Github user powerYao commented on the pull request: https://github.com/apache/tomcat/commit/d91d7a802b67ab049b33df9db017ef31d3247450#commitcomment-22377283 why the origin code hava ( ) ? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] tomcat pull request #58: add nioendpoint note

2017-06-05 Thread powerYao
GitHub user powerYao opened a pull request: https://github.com/apache/tomcat/pull/58 add nioendpoint note You can merge this pull request into a Git repository by running: $ git pull https://github.com/powerYao/tomcat trunk Alternatively you can review and apply these

[GitHub] tomcat pull request #59: add some useful note

2017-06-05 Thread powerYao
GitHub user powerYao opened a pull request: https://github.com/apache/tomcat/pull/59 add some useful note You can merge this pull request into a Git repository by running: $ git pull https://github.com/powerYao/tomcat trunk Alternatively you can review and apply these

[GitHub] tomcat issue #63: added portOffset attribute to server.xml per BZ-61171

2017-06-10 Thread powerYao
Github user powerYao commented on the issue: https://github.com/apache/tomcat/pull/63 i feel it's not very necessary for tomcat.What if the port is already bound? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] tomcat issue #59: add some useful note

2017-06-21 Thread powerYao
Github user powerYao commented on the issue: https://github.com/apache/tomcat/pull/59 I get it,thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or